Bounties e2e test by dhirajs0 · Pull Request #399 · open-web3-stack/polkadot-ecosystem-tests

dhirajs0 · 2025-09-09T11:15:42Z

Added end-to-end tests to cover the main flows of the pallet_bounties module.

Key scenarios covered:

Creating a bounty
Curator assignment and acceptance
Funding and extending a bounty
Awarding and claiming a bounty
Bounty closure and payout
Handling bounty rejection or cancellation

Closes #292 .

dhirajs0 · 2025-09-09T13:51:05Z

Thanks for the early feedback. I will incorporate the suggested changes.

rockbmb · 2025-09-09T14:00:27Z

I am aware this is a draft PR; whenever it's ready, ping me for a full review.

…d acceptance test

… test

rockbmb · 2025-09-22T20:52:21Z

Will take a look later in the week!

github-actions

The ensureSpendPeriodAvailable function is incorrectly called with the client object instead of lastSpendPeriodBlock in two different tests. This will lead to test failures. Otherwise, the changes look good and provide comprehensive test coverage for the bounties pallet.

…in calls

github-actions

The submitted code is well-structured and provides extensive test coverage for the bounties pallet. However, there are a few issues that need to be addressed, including an incorrect null check, a misleading comment, and several typos in comments and snapshot names. Addressing these points will improve the code's correctness and maintainability.

Suggestions that couldn't be attached to a specific line

packages/shared/src/bounties.ts:1568, 1726

There is a typo in the comments on these lines. 'amout' should be 'amount'.

github-actions · 2025-09-29T21:34:09Z

+  // verify the transfer event
+  await checkSystemEvents(client, { section: 'balances', method: 'Transfer' })
+    .redact({ redactKeys: /from|to/ })
+    .toMatchSnapshot('bounty value transfered to treasury')


There is a typo in the snapshot name: 'bounty value transfered to treasury'. 'transfered' should be 'transferred'.

github-actions · 2025-09-29T21:34:09Z

+  expect(bountyStatus.status.isActive).toBe(true)
+
+  // Charlie (public user) tries to unassign curator immediately (premature)
+  // Using scheduleInlineCallWithOrigin to simulate public call


The comment // Using scheduleInlineCallWithOrigin to simulate public call is misleading. The test actually uses sendTransaction on line 2165 to send a transaction from a regular account (charlie), not scheduleInlineCallWithOrigin. Please update the comment to accurately reflect that a public user is attempting the action, for example: // Charlie (a public user) tries to unassign the curator.

rockbmb

Great stuff!

Every bounties pallet's extrinsic is exercised at least once
- pokeDeposit still not available
Every event type appears at least once
- DepositPoked still not available, either
Almost every variant of the Error<T> enum is checked at least once
- 100% coverage is a distraction, but exercising each at least once is desirable
snapshots redact temporal data, as they should
Broad selection of scenarios

The PR is already large enough, feel free to address my comments in a future PR.

rockbmb · 2025-09-30T01:58:01Z

+  await client.dev.newBlock()
+
+  // claim the bounty
+  const claimBountyTx = client.api.tx.bounties.claimBounty(bountyIndex)


This is the successful case, which is good to cover.

However, the failure code path is not exercised, which would also be good:
https://github.com/paritytech/polkadot-sdk/blob/c3f62bf918ef6879390dc6a2cf9f91caac23f5b5/substrate/frame/bounties/src/lib.rs#L734-L736

if let BountyStatus::PendingPayout { curator, beneficiary, unlock_at } = bounty.status { ... } else { // This arm of the conditional Err(Error::<T, I>::UnexpectedStatus.into()) }

Can be left to a future PR.

added the failure code in the latest commits

rockbmb · 2025-09-30T02:00:31Z

+ * Test: Bounty closure in PendingPayout state (should fail)
+ *
+ * Verifies:
+ * - Bounty closure fails with PendingPayout error when in PendingPayout state (GeneralAdmin must unassign curator first)


Suggested change

* - Bounty closure fails with PendingPayout error when in PendingPayout state (GeneralAdmin must unassign curator first)

* - Bounty closure fails with `PendingPayout` error when in `PendingPayout` state (`GeneralAdmin` must unassign curator first)

This is pedantry on my part, but backticks (``) when referring to code in comments are preferable, imo.

You are right, i am updating it.

added backticks for code in all the opening comments.

Thanks. Like I said, it's not important, but it makes comments slightly easier to read.

rockbmb · 2025-09-30T02:09:00Z

+  const updateDueBefore = bountyForExtending.status.asActive.updateDue.toNumber()
+
+  // extend the bounty expiry
+  const extendBountyTx = client.api.tx.bounties.extendBountyExpiry(bountyIndex, 'Testing the bounty extension')


This is the successful case;

A few others would be interesting to test: https://github.com/paritytech/polkadot-sdk/blob/c3f62bf918ef6879390dc6a2cf9f91caac23f5b5/substrate/frame/bounties/src/lib.rs#L855-L862

match bounty.status { BountyStatus::Active { ref curator, ref mut update_due } => { // A check to the caller. Really basic, but the compiler can't catch these things. ensure!(*curator == signer, Error::<T, I>::RequireCurator); *update_due = Self::treasury_block_number() .saturating_add(T::BountyUpdatePeriod::get()) .max(*update_due); }, // A check that exercises this code path _ => return Err(Error::<T, I>::UnexpectedStatus.into()),

As my other such comments, this can be left to a future PR.

As my other such comments, this can be left to a future PR.

Sure. Will add in a future PR

rockbmb · 2025-09-30T02:19:23Z

+/// -------
+
+// initial funding balance for accounts
+const TEST_ACCOUNT_BALANCE = 100000000000000n


This test is going to be run on post-AHM KAH (in fact, it already can; remind me to ping you this week to pair on this; will be useful later), and soon, post-migration PAH.

Could you make this a large multiple of const.balances.existentialDeposit?

dhirajs0 · 2025-10-05T21:02:24Z

Every bounties pallet's extrinsic is exercised at least once

pokeDeposit still not available

Every event type appears at least once

DepositPoked still not available, either

pokeDeposit and DepositPoked is not available as I was using the bounties code from the branch in the ahm dryrun repo, should have taken the latest code from polkadot-sdk .

The PR is already large enough, feel free to address my comments in a future PR.

Sure, I will address these in a future PR

dhirajs0 · 2025-10-05T21:38:42Z

Thank you very much for all the suggestions, I'm excited to put these best practices into action on my next PR.

rockbmb · 2025-10-06T20:51:55Z

pokeDeposit and DepositPoked is not available

I know, and now I know that you know! I was just commenting for future reference i.e. that at the time this PR was written, these were not available, in other words, that coverage is complete (until those come online)

dhirajs0 added 4 commits September 4, 2025 22:03

bounties module added

d6ec0f7

Creating a bounty test added

b2aeffb

bounty approval flow test added

289da9e

curator assignment and acceptance test added

6583de2

rockbmb reviewed Sep 9, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

rockbmb reviewed Sep 9, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

rockbmb reviewed Sep 9, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

dhirajs0 added 2 commits September 9, 2025 23:31

rafac: setupTestAccounts function using a map

c1279db

rafac: bountyValue is changed to exential deposit multiple

aacbce1

rockbmb mentioned this pull request Sep 9, 2025

Refactor E2E suites to allow AHM integration #384

Merged

7 tasks

dhirajs0 added 8 commits September 10, 2025 19:52

fix: bountyValue type is set to BigInt

ac3066a

Bountry approval flow with Curator test added

46a8d53

fix: added event verification in bountyApprovalWithCuratorTest

0e4e845

bountyFundingTest added

b68fbe8

Bounty funding for ApprovedWithCurator Bounties test added

31dd6ac

Curator assignment and acceptance test added

39c758e

improve: setStorage replaced with extrinsics call

cd0d353

helper function getBountyEvents added

b6baac5

rockbmb reviewed Sep 13, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

dhirajs0 added 9 commits September 15, 2025 12:54

setStorage replaces with Extrinsic call in fundind with curator test

64d8ce6

replaced the setStorage with Extrinsic calls in curator assignment an…

bca934b

…d acceptance test

bounty extension test added

33019a2

bounty awading and claiming tests added

7e20cdb

bounty closure on proposed test added

1f4ac58

bounty closure in funded state test added

8c5ae5e

helper function to log all events added

e5403b6

update: blance slash check added in bounty closure of proposed bounty…

3bff36d

… test

bounty closure in active state test added

de4380d

refac: defined type of params

1bf7448

dhirajs0 marked this pull request as ready for review September 19, 2025 16:33

dhirajs0 requested a review from rockbmb September 19, 2025 16:33

snanpshots updated for polkadot and kusama

0f24e0d

github-actions Bot reviewed Sep 22, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

Comment thread packages/shared/src/bounties.ts Outdated

dhirajs0 added 4 commits September 23, 2025 11:27

fix

37cfb5a

Merge branch 'master' into bounties-e2e

e212286

refac: parameterize the sendTransation and scheduleInlineCallWithOrig…

c37a27e

…in calls

readme: added bounties tests convered

ed92bea

rockbmb reviewed Sep 25, 2025

View reviewed changes

Comment thread packages/shared/src/bounties.ts Outdated

dhirajs0 added 3 commits September 26, 2025 17:17

devAccounts replaced with testAccounts

379c601

set the lastSpendPeriod such that the next spend is few block ahead

67da6c0

snapshot of bounties updated

6a0f9fc

rockbmb mentioned this pull request Sep 27, 2025

Asset Hub Migration: basic end-to-end test coverage paritytech/ahm-dryrun#2

Open

58 tasks

dhirajs0 and others added 4 commits September 30, 2025 00:47

added setLastSpendPeriodBlockNumber() fn for repeated logic

656ddd4

added extractExtrinsicFailedEvent() for repeated logic

7fb4b4f

minor improvements

871110a

Merge branch 'master' into bounties-e2e

e98793a

github-actions Bot reviewed Sep 29, 2025

View reviewed changes

rockbmb approved these changes Sep 30, 2025

View reviewed changes

dhirajs0 added 2 commits September 30, 2025 08:15

linter warning fixed

1598eb0

empty events fixed and docs updated

5a11ba6

dhirajs0 added 2 commits October 6, 2025 02:44

snapshot updated

33d2688

openng docs updated

c1e3a92

rockbmb merged commit 9e80e3c into open-web3-stack:master Oct 7, 2025
247 of 258 checks passed

rockbmb mentioned this pull request Oct 10, 2025

Migrate newly added Bounties test suite from Kusama to KAH #440

Closed

	* - Bounty closure fails with PendingPayout error when in PendingPayout state (GeneralAdmin must unassign curator first)
	* - Bounty closure fails with `PendingPayout` error when in `PendingPayout` state (`GeneralAdmin` must unassign curator first)

Conversation

dhirajs0 commented Sep 9, 2025 • edited by rockbmb Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dhirajs0 commented Sep 9, 2025

Uh oh!

rockbmb commented Sep 9, 2025

Uh oh!

Uh oh!

rockbmb commented Sep 22, 2025

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions Bot left a comment

Choose a reason for hiding this comment

Suggestions that couldn't be attached to a specific line

Uh oh!

Uh oh!

github-actions Bot Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

github-actions Bot Sep 29, 2025

Choose a reason for hiding this comment

Uh oh!

rockbmb left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rockbmb Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rockbmb Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

rockbmb Oct 6, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rockbmb Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

rockbmb Sep 30, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 Oct 5, 2025

Choose a reason for hiding this comment

Uh oh!

dhirajs0 commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhirajs0 commented Oct 5, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

rockbmb commented Oct 6, 2025

Uh oh!

dhirajs0 commented Sep 9, 2025 •

edited by rockbmb

Loading

dhirajs0 Oct 5, 2025 •

edited

Loading

dhirajs0 Oct 5, 2025 •

edited

Loading

dhirajs0 Oct 5, 2025 •

edited

Loading

dhirajs0 commented Oct 5, 2025 •

edited

Loading

dhirajs0 commented Oct 5, 2025 •

edited

Loading