fix proxy tests

[xlc]

fix proxy e2e tests

[xlc]

this is not exactly right

[xlc]

@rockbmb would you be able to continue on this? also not exactly sure what's wrong but running those tests locally was very very slow for me

[github-actions]

The changes introduce a new useRelayBlockNumber parameter to handle differences in block numbering between parachains and relay chains in proxy-related tests. However, this new logic is applied incorrectly in two places, likely causing test failures.

[github-actions]

In createKillPureProxyTest, the currBlockNumber is fetched using getBlockNumber, which may return a relay chain block number. This block number is then passed to the proxy.killPure extrinsic. The killPure extrinsic requires the block number of the parachain where the proxy was created, not a relay chain block number. Using the relay block number will cause the extrinsic to fail as it won't be able to find the proxy's creation event.

[github-actions]

In proxyAnnouncementLifecycleTest, the expected block height for a re-announced proxy call is hardcoded to currBlockNumber + 4. This offset is likely incorrect for tests that do not use the relay block number (i.e., when useRelayBlockNumber is false), where the expected offset should be +2. Applying the +4 offset unconditionally will break these tests. The offset should be determined based on the value of useRelayBlockNumber.

[rockbmb]

@xlc I can take over.

[rockbmb]

I also had to do this in #384 .

polkadot-ecosystem-tests/packages/shared/src/helpers/index.ts

Lines 364 to 378 in fd2ca4e

	/**
	* Get the last known block number for a given chain.
	*
	* The block provider might be local or external (e.g. a parachain querying its relay chain).
	*
	* @param api Promise-based RPC wrapper around the endpoint of a Polkadot chain.
	* @returns The last known block number if relay, the relay chain block number the most recent parablock was anchored
	* to if parachain.
	*/
	export async function getBlockNumber(api: ApiPromise, blockProvider: BlockProvider): Promise<number> {
	return await match(blockProvider)
	.with('Local', async () => (await api.rpc.chain.getHeader()).number.toNumber())
	.with('NonLocal', async () => ((await api.query.parachainSystem.lastRelayChainBlockNumber()) as any).toNumber())
	.exhaustive()
	}

[rockbmb]

#384 fixes the proxy tests' differing announcement block numbers, so closing in favor of it.