Skip to content

Multisig e2e followup #323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rockbmb merged 4 commits into from
Jul 8, 2025
Merged

Multisig e2e followup #323

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8af1b73
Add extra multisig e2e tests
rockbmb Jul 7, 2025
9941f57
Update `README.md`
rockbmb Jul 7, 2025
a2585e6
Update snapshots
rockbmb Jul 7, 2025
1657917
Redact a test snapshot
rockbmb Jul 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,10 @@ These include:
- a proxy of a given type can always execute calls which that proxy type is allowed to execute
- a proxy of a given type can never execute calls that its proxy type disallowws it from running
- see the section below for more
- E2E suite for multisig accounts and operations
- multisig creation, approval and execution
- multisig cancellation, and deposit refunding
- diverse failure modes tested (wrong timepoints, malformed execution/approval calls)
- E2E suite for vesting
- normal (signed) and forced (root) vested transfers
- forced (root) vesting schedule removal
Expand Down
126 changes: 88 additions & 38 deletions packages/kusama/src/__snapshots__/assetHubKusama.multisig.e2e.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
// Vitest Snapshot v1, https://vitest.dev/guide/snapshot.html

exports[`AssetHubKusama Multisig > a redundant approval fails > events when redundant approval fails 1`] = `
exports[`AssetHubKusama Multisig > approval with max weight too low fails > events when Bob executes multisig operation with low weight 1`] = `[]`;

exports[`AssetHubKusama Multisig > approval with sender in signatories fails > events when approval with sender in signatories fails 1`] = `
[
{
"data": {
Expand All @@ -25,8 +27,6 @@ exports[`AssetHubKusama Multisig > a redundant approval fails > events when redu
]
`;

exports[`AssetHubKusama Multisig > approval with max weight too low fails > events when Bob executes multisig operation with low weight 1`] = `[]`;

exports[`AssetHubKusama Multisig > approval with signatories out of order fails > events when approval with signatories out of order fails 1`] = `
[
{
Expand Down Expand Up @@ -124,13 +124,13 @@ exports[`AssetHubKusama Multisig > beginning multisig approval with \`approveAsM
]
`;

exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation fails > events when cancelling multisig with bogus call hash fails 1`] = `
exports[`AssetHubKusama Multisig > cancellation with sender in signatories fails > events for cancellation with sender in signatories fails 1`] = `
[
{
"data": {
"dispatchError": {
"Module": {
"error": "0x07000000",
"error": "0x06000000",
"index": "(rounded 40)",
},
},
Expand All @@ -149,7 +149,7 @@ exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation
]
`;

exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation fails > events when cancelling multisig with wrong signatories fails 1`] = `
exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation fails > events when cancelling multisig with bogus call hash fails 1`] = `
[
{
"data": {
Expand All @@ -174,22 +174,22 @@ exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation
]
`;

exports[`AssetHubKusama Multisig > creating a multisig with threshold < 2 fails > events when creating multisig with threshold < 2 fails 1`] = `
exports[`AssetHubKusama Multisig > cancelling a non-existent multisig operation fails > events when cancelling multisig with wrong signatories fails 1`] = `
[
{
"data": {
"dispatchError": {
"Module": {
"error": "0x00000000",
"index": 41,
"error": "0x07000000",
"index": "(rounded 40)",
},
},
"dispatchInfo": {
"class": "Normal",
"paysFee": "Yes",
"weight": {
"proofSize": "(rounded 1000000)",
"refTime": "(rounded 1900000000)",
"proofSize": "(rounded 20000)",
"refTime": "(rounded 700000000)",
},
},
},
Expand All @@ -199,47 +199,38 @@ exports[`AssetHubKusama Multisig > creating a multisig with threshold < 2 fails
]
`;

exports[`AssetHubKusama Multisig > final approval with \`approveAsMulti\` does not lead to execution > events when Bob makes final approval with approveAsMulti 1`] = `
exports[`AssetHubKusama Multisig > creating a multisig with threshold < 2 fails > events when creating multisig with threshold < 2 fails 1`] = `
[
{
"data": {
"approving": "FoQJpPyadYccjavVdTWxpxU7rUEaYhfLCPwXgkfD6Zat9QP",
"callHash": "(hash)",
"multisig": "FZ29umykw5WDCAABs2BFzyztRn3BeJEUhqtbCFfKGZhS2kc",
"timepoint": {
"height": "(redacted)",
"index": 2,
"dispatchError": {
"Module": {
"error": "0x00000000",
"index": 41,
},
},
"dispatchInfo": {
"class": "Normal",
"paysFee": "Yes",
"weight": {
"proofSize": "(rounded 1000000)",
"refTime": "(rounded 1900000000)",
},
},
},
"method": "MultisigApproval",
"section": "multisig",
},
]
`;

exports[`AssetHubKusama Multisig > first call with unexpected timepoint fails > events when Alice starts multisig operation with \`approveAsMulti\` 1`] = `[]`;

exports[`AssetHubKusama Multisig > multisig approval with remaining signatories out of order fails > events when Alice creates multisig for ordering test 1`] = `
[
{
"data": {
"approving": "HNZata7iMYWmk5RvZRTiAsSDhV8366zq2YGb3tLH5Upf74F",
"callHash": "(hash)",
"multisig": "EF9xmEeFv3nNVM3HyLAMTV5TU8jua5FRXCE116yfbbrZbCL",
},
"method": "NewMultisig",
"section": "multisig",
"method": "ExtrinsicFailed",
"section": "system",
},
]
`;

exports[`AssetHubKusama Multisig > multisig approval with remaining signatories out of order fails > events when multisig approval with signatories out of order fails 1`] = `
exports[`AssetHubKusama Multisig > execution with sender in signatories fails > events when creation with sender in signatories fails 1`] = `
[
{
"data": {
"dispatchError": {
"Module": {
"error": "0x05000000",
"error": "0x06000000",
"index": 41,
},
},
Expand All @@ -258,6 +249,26 @@ exports[`AssetHubKusama Multisig > multisig approval with remaining signatories
]
`;

exports[`AssetHubKusama Multisig > final approval with \`approveAsMulti\` does not lead to execution > events when Bob makes final approval with approveAsMulti 1`] = `
[
{
"data": {
"approving": "FoQJpPyadYccjavVdTWxpxU7rUEaYhfLCPwXgkfD6Zat9QP",
"callHash": "(hash)",
"multisig": "FZ29umykw5WDCAABs2BFzyztRn3BeJEUhqtbCFfKGZhS2kc",
"timepoint": {
"height": "(redacted)",
"index": 2,
},
},
"method": "MultisigApproval",
"section": "multisig",
},
]
`;

exports[`AssetHubKusama Multisig > first call with unexpected timepoint fails > events when Alice starts multisig operation with \`approveAsMulti\` 1`] = `[]`;

exports[`AssetHubKusama Multisig > multisig cancellation with remaining signatories out of order fails > events when Alice creates multisig for cancel ordering test 1`] = `
[
{
Expand Down Expand Up @@ -379,6 +390,45 @@ exports[`AssetHubKusama Multisig > multisig creation with too many signatories f
]
`;

exports[`AssetHubKusama Multisig > multisig execution with remaining signatories out of order fails > events when Alice creates multisig for ordering test 1`] = `
[
{
"data": {
"approving": "HNZata7iMYWmk5RvZRTiAsSDhV8366zq2YGb3tLH5Upf74F",
"callHash": "(hash)",
"multisig": "EF9xmEeFv3nNVM3HyLAMTV5TU8jua5FRXCE116yfbbrZbCL",
},
"method": "NewMultisig",
"section": "multisig",
},
]
`;

exports[`AssetHubKusama Multisig > multisig execution with remaining signatories out of order fails > events when multisig approval with signatories out of order fails 1`] = `
[
{
"data": {
"dispatchError": {
"Module": {
"error": "0x05000000",
"index": 41,
},
},
"dispatchInfo": {
"class": "Normal",
"paysFee": "Yes",
"weight": {
"proofSize": "(rounded 1000000)",
"refTime": "(rounded 1900000000)",
},
},
},
"method": "ExtrinsicFailed",
"section": "system",
},
]
`;

exports[`AssetHubKusama Multisig > non-depositor tries to cancel multisig fails > events when non-depositor tries to cancel multisig fails 1`] = `
[
{
Expand Down
Loading