xtokens: ensuring exact error from xcm propagated #659
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zjb0807
reviewed
Nov 23, 2021
xlc
approved these changes
Nov 23, 2021
Member
xlc
left a comment
xlc
left a comment
There was a problem hiding this comment.
I am fine with this. Later can be updated once paritytech/substrate#10242 is available
Codecov Report
@@ Coverage Diff @@
## master #659 +/- ##
==========================================
- Coverage 75.93% 75.65% -0.28%
==========================================
Files 78 78
Lines 6549 6577 +28
==========================================
+ Hits 4973 4976 +3
- Misses 1576 1601 +25
Continue to review full report at Codecov.
|
Contributor
Author
|
replaced with logger. added comment to use paritytech/substrate#10242 as soon as ready. |
zjb0807
reviewed
Nov 24, 2021
xtokens/src/lib.rs
Outdated
| .ensure_complete() | ||
| .map_err(|_| Error::<T>::XcmExecutionFailed)?; | ||
| .map_err(|error| { | ||
| log::trace!("Failed execute transfer message with {:?}", error); |
Contributor
There was a problem hiding this comment.
Suggested change
| log::trace!("Failed execute transfer message with {:?}", error); | |
| log::error!(target: "xtokens", "Failed execute transfer message with {:?}", error); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xcmp may fail because of dozens of reasons. it is very hard to debug and hard to setup.
so solution is to be very specific about failure reason.