Added a test for the userAgentString

open-voip-alliance · Mar 2, 2020 · 2858184 · 2858184
1 parent 4cafd5d
commit 2858184
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 2 deletions.
diff --git a/test/_helpers.ts b/test/_helpers.ts
@@ -22,9 +22,14 @@ export function defaultTransportFactory() {
 
 export function createClientImpl(
   uaFactory: UAFactory,
-  transportFactory: TransportFactory
+  transportFactory: TransportFactory,
+  additionalOptions: UserAgentOptions = {}
 ): ClientImpl {
-  return new ClientImpl(uaFactory, transportFactory, minimalOptions());
+  return new ClientImpl(
+    uaFactory,
+    transportFactory,
+    Object.assign(minimalOptions(), additionalOptions)
+  );
 }
 
 export function createClient() {

diff --git a/test/client-connect.ts b/test/client-connect.ts
@@ -218,3 +218,12 @@ test.serial('ua.start called on first connect', t => {
 
   t.true(ua.start.called);
 });
+
+test.serial('userAgentString is correct', t => {
+  sinon.stub(Features, 'checkRequired').returns(true);
+  const userAgentString = 'Test UserAgent string';
+  const client = createClientImpl(defaultUAFactory(), defaultTransportFactory(), {
+    userAgentString
+  });
+  t.is((client as any).transport.uaOptions.userAgentString, userAgentString);
+});