Skip to content

Annotations for enum members #812

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lquerel merged 5 commits into from
Jul 2, 2025
Merged

Annotations for enum members #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6f0449f
Add annotations to enum members
Jul 1, 2025
9106d8f
nits
Jul 1, 2025
98cdf8f
update schema json
Jul 1, 2025
026a28f
consistent null serialization for members
Jul 1, 2025
d296d07
Merge branch 'main' into annotations-for-enum-members
lquerel Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions crates/weaver_emit/src/attributes.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
EnumEntriesSpec {
id: "second".to_owned(),
Expand All @@ -487,6 +488,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
],
},
Expand All @@ -509,6 +511,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
EnumEntriesSpec {
id: "second".to_owned(),
Expand All @@ -517,6 +520,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
],
},
Expand All @@ -539,6 +543,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
EnumEntriesSpec {
id: "second".to_owned(),
Expand All @@ -547,6 +552,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
],
},
Expand All @@ -569,6 +575,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
},
EnumEntriesSpec {
id: "second".to_owned(),
Expand All @@ -577,6 +584,7 @@ mod tests {
note: None,
stability: None,
deprecated: None,
annotations: None,
Copy link
Copy Markdown
Contributor

@jsuereth jsuereth Jul 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerbly / @lquerel After seeing this type of change bloat PRs a thousand times,

How do we feel about using the DEFAULT syntax so this isn't so tedious when safely adding new fields?

e.g.:

EnumEntriesSpec {
  id: "non-default".to_owned(),
  ...Default::default(),
}

Instead of these more verbose updates where it's harder to see the content of what has changed...

Copy link
Copy Markdown
Contributor

@lquerel lquerel Jul 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree

},
],
},
Expand Down
8 changes: 8 additions & 0 deletions crates/weaver_forge/data/registry-db.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,14 @@ groups:
stability: stable
value: 'cosmosdb'
brief: 'Microsoft Azure Cosmos DB'
deprecated: "Replaced by `azure.cosmosdb`."
annotations:
code_generation:
exclude: true
- id: azure_cosmosdb
stability: stable
value: 'azure.cosmosdb'
brief: 'Microsoft Azure Cosmos DB'
- id: dynamodb
stability: stable
value: 'dynamodb'
Expand Down
Loading
Loading