Rename resource group type to entity.#714
Merged
jsuereth merged 5 commits intoopen-telemetry:mainfrom Apr 30, 2025
Merged
Conversation
This is part of the move to Entity as a grouping of attributes on
Resource. An Entity represents a named set of attributes with its
own versioning defined by weaver / semantic conventions. Combined
with the previous `entity_associations` work, this unlocks
validating Resource in `live_check`.
Note: This is breaking for all tempaltes that directly use `group.type`.
While JQ helpers have been updated to support the chagne, direct
group.type usage will see `entity` in the future.
Contributor
Author
|
Added a fix to prevent semconv from breaking with this: open-telemetry/semantic-conventions#2192 |
lmolkova
approved these changes
Apr 28, 2025
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
lmolkova
changed the title
resource group type to `entity.resource group type to entity.
lmolkova
moved this from To consider for the next release
to Next Release
in OTel Weaver Project
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #714 +/- ##
=======================================
- Coverage 74.7% 74.6% -0.1%
=======================================
Files 67 67
Lines 5093 5093
=======================================
- Hits 3805 3804 -1
- Misses 1288 1289 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-project-automation
bot
moved this from Next Release
to Done
in OTel Weaver Project
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the move to Entity as a grouping of attributes on Resource. An Entity represents a named set of attributes with its own versioning defined by weaver / semantic conventions. Combined with the previous
entity_associationswork, this unlocks validating Resource inlive_check.Note: This is breaking for all templates that directly use
group.type.While JQ helpers have been updated to support the chagne, direct
group.type usage will see
entityin the future.