Skip to content

Use manifest/2.0, resolved/2.0 for file format, add version bump enforcement #1333

Merged
jsuereth merged 7 commits intoopen-telemetry:mainfrom
lmolkova:major-minor-pattern-for-file-format
Apr 7, 2026
Merged

Use manifest/2.0, resolved/2.0 for file format, add version bump enforcement #1333
jsuereth merged 7 commits intoopen-telemetry:mainfrom
lmolkova:major-minor-pattern-for-file-format

Conversation

@lmolkova
Copy link
Copy Markdown
Member

@lmolkova lmolkova commented Apr 4, 2026

Patch version is removed from manifest and resolved file format.

This change follows a pattern used in configuration https://github.com/open-telemetry/opentelemetry-configuration/blob/main/VERSIONING.md#file-format and a TC call discussion in open-telemetry/opentelemetry-specification#4815 (comment)

The spec will need to include a language explaining that consumer that supports vN.M may warn but should read schemas of vN.P (P > M) and ignore unknown properties. Consumer that only supports vN.* should not attempt to read vM.*.

Added checks to validate that removing fields requires major version bump and adding fields requires minor version bump.

Will address forward-compat issues in a follow ups

@lmolkova lmolkova requested a review from a team as a code owner April 4, 2026 07:03
@lmolkova lmolkova changed the title Use manifest/2.0, resolved/2.0, etc for file format, add version bump enforcement Use manifest/2.0, resolved/2.0 for file format, add version bump enforcement Apr 4, 2026
Comment thread crates/xtask/src/schema_compat.rs Fixed
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.7%. Comparing base (bcfb76f) to head (723250d).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #1333     +/-   ##
=======================================
- Coverage   81.7%   81.7%   -0.1%     
=======================================
  Files        113     113             
  Lines       9718    9718             
=======================================
- Hits        7942    7940      -2     
- Misses      1776    1778      +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lmolkova lmolkova force-pushed the major-minor-pattern-for-file-format branch from 940aa3c to f917b87 Compare April 4, 2026 15:47
Copy link
Copy Markdown
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with this path forward

@jsuereth jsuereth merged commit e97aff1 into open-telemetry:main Apr 7, 2026
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants