Fix the unit of metric.process.runtime.jvm.system.cpu.load_1m to be {run_queue_item} #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@trask this is a leftover from the metrics stabilization - didn't catch this problem before. |
mateuszrzeszutek
approved these changes
Jun 7, 2023
trask
reviewed
Jun 7, 2023
trask
reviewed
Jun 9, 2023
joaopgrassi
approved these changes
Jun 20, 2023
zeitlinger
added a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 20, 2023
zeitlinger
added a commit
to zeitlinger/opentelemetry-java-instrumentation
that referenced
this pull request
Jun 20, 2023
trask
approved these changes
Jun 27, 2023
jack-berg
approved these changes
Jun 27, 2023
|
@zeitlinger sorry, can you resolve conflicts again? |
done |
…{run_queue_item}"
arminru
changed the title
arminru
approved these changes
Jul 21, 2023
rapphil
pushed a commit
to rapphil/semantic-conventions
that referenced
this pull request
Aug 14, 2023
…run_queue_item} (open-telemetry#95) Co-authored-by: Armin Ruech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix the unit of metric.process.runtime.jvm.system.cpu.load_1m to be "{core}"
This is particularly obvious when you see that the the metric name is converted to
process_runtime_jvm_system_cpu_load_1m_ratio{}in prometheus.