[google-genai] Add standard definitions to Google GenAI systems#3517
[google-genai] Add standard definitions to Google GenAI systems#3517Rima-ag wants to merge 9 commits intoopen-telemetry:mainfrom
Conversation
lmolkova
moved this from Untriaged
to Awaiting codeowners approval
in Semantic Conventions Triage
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
MikeGoldsmith
left a comment
MikeGoldsmith
left a comment
There was a problem hiding this comment.
Looks pretty good @Rima-ag. Thanks for working on this.
|
|
||
| `gen_ai.provider.name` MUST be set to `"gcp.gen_ai"`, `"gcp.vertex_ai"`, or `"gcp.gemini"` and SHOULD be provided **at span creation time**. | ||
|
|
||
| **Span name** SHOULD be `{gen_ai.operation.name} {gen_ai.request.model}`. |
There was a problem hiding this comment.
These look identical to the base GenAI convention so no need to restate it here unless Google deviates. If the intent is just to inherit the base behavior, I think can be dropped.
There was a problem hiding this comment.
The direction the GenAI semantic documentation is going with is for every provider's doc to be self explanatory, this is why this is restated here
I also think it's easier to not have to compare 2 different pages to understand how spans will be created
| requirement_level: | ||
| conditionally_required: If not default (443). | ||
|
|
||
| - id: span.gen_ai.gcp.client |
There was a problem hiding this comment.
This looks the same as the base attributes.gen_ai.inference.client - does it add anything different? If not, we could remove.
There was a problem hiding this comment.
That's mostly true, the only difference is the note about gen_ai.provider.name that is injected in the documentation. Other providers are also documented with this pattern.
In #3486 we'll be adding a Google specific attribute
trask
moved this to In Progress
in GenAI Semantic Conventions and Instrumentation libraries
github-project-automation
Bot
moved this from In Progress
to Done
in GenAI Semantic Conventions and Instrumentation libraries
|
#3383 already added standard definitions |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
5 participants
open-telemetry/semantic-conventions-genai#27
Changes
Create documentation for the common span definition of Google systems. This will make it easier to review #3486 that is adding Google-specific semconv.
Merge requirement checklist
[chore]