Adds GraphQL Semantic Convention from Otel Workgroup#3515
Adds GraphQL Semantic Convention from Otel Workgroup#3515PascalSenn wants to merge 7 commits intoopen-telemetry:mainfrom
Conversation
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
@trask Can you let me know the process to get this reviewed? |
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
|
re-opening for discussion! @PascalSenn also check out open-telemetry/opentelemetry-specification#4906 there has been quite a bit of progress since we discussed last year about the option of hosting semantic conventions outside of this repository. I think the work is pretty bleeding edge still but may be ready for external usage soon. In the meantime, let's review and discuss the GraphQL semantic conventions here. |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
…consistency - Updated error attributes in events.yaml to clarify the relationship between GraphQL-specific error details and exception information. - Renamed metrics in metrics.yaml for consistency, changing `active_requests` to `request.active`. - Revised registry.yaml to enhance attribute descriptions and examples, including the addition of `graphql.document.locations` and renaming selection attributes to field attributes. - Improved span definitions in spans.yaml to align with updated field naming conventions and clarified requirements for document IDs and hashes.
|
@thompson-tomo @trask can we reopen this PR? |
thompson-tomo
left a comment
There was a problem hiding this comment.
Just a couple of small doc tweaks which will need a fresh markdown generated.
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Important
This is a working draft and is NOT intended to be merged yet. Final approval is still pending from both the OpenTelemetry Semantic Conventions maintainers and the GraphQL OpenTelemetry Working Group. This PR has been opened early to get feedback from the OTel side and be the base for discussion while the specification is being finalized.
Changes
This PR adds comprehensive GraphQL semantic conventions, developed by the GraphQL OpenTelemetry Working Group, to the OpenTelemetry Semantic Conventions repository.
Origin
This specification was developed in the graphql/graphql-wg otel-wg subcommittee over multiple working group sessions. Key contributors and participants include members from the GraphQL and OpenTelemetry communities working together to define instrumentation standards for GraphQL.
The specification intends to supersede the existing minimal GraphQL semantic conventions (previously only a single server span with 3 attributes) with a comprehensive convention covering the full GraphQL request lifecycle.
graphql.operation.nameis opt-in on metrics;graphql.document.hashandgraphql.document.idare preferred identifiersgraphql.error.*andexception.*attributesmetrics, distinct from request-level tracking
People involved
This work was developed by the GraphQL OpenTelemetry Working Group, a subcommittee of the GraphQL Working Group. Participants include representatives from across the GraphQL ecosystem working on instrumentation standards.
Important
The workgroup meets every third week of the month on thursday Checkout the calendar
In case you want to join add yourself to the agenda over at GraphQL OpenTelemetry Working Group
Merge requirement checklist
[chore]