BREAKING: Remove server.socket.address attribute from http and rpc metrics#350
Merged
joaopgrassi merged 2 commits intoopen-telemetry:mainfrom Oct 2, 2023
Merged
Conversation
trask
force-pushed
the
remove-socket-address-from-metric
branch
4 times, most recently
from
b1586cf to
bd7595b
Compare
joaopgrassi
approved these changes
Sep 27, 2023
Contributor
|
@lmolkova I guess we should also apply this change to #163 (for adding messaging metrics): https://github.com/open-telemetry/semantic-conventions/pull/163/files#diff-1c3afdf1b3b840fc9e4c17a2110573d1656b7e27d75b13f4ce97e2daff22517bR47 |
pyohannes
approved these changes
Sep 27, 2023
Merged
AlexanderWert
approved these changes
Sep 27, 2023
arminru
approved these changes
Sep 27, 2023
lmolkova
approved these changes
Sep 27, 2023
trask
force-pushed
the
remove-socket-address-from-metric
branch
from
bd7595b to
ec7feeb
Compare
jsuereth
approved these changes
Oct 2, 2023
Contributor
jsuereth
left a comment
jsuereth
left a comment
There was a problem hiding this comment.
I would like to see us update schema files to handle this at some point, but this is certainly a breaking change (and a very needed one).
trask
changed the title
server.socket.address attribute from http and rpc metricsserver.socket.address attribute from http and rpc metrics
breedx-splk
pushed a commit
to breedx-splk/semantic-conventions
that referenced
this pull request
Oct 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #341
Changes
Removes
server.socket.addressattribute from http and rpc metrics.Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.