Define FaaS exception event#3451
Conversation
9bb2167 to
5e80453
Compare
5e80453 to
10756c2
Compare
|
This PR contains changes to area(s) that do not have an active SIG/project and will be auto-closed:
Such changes may be rejected or put on hold until a new SIG/project is established. Please refer to the Semantic Convention Areas |
Isn't a Function as a Service invocation nothing else than a HTTP request or RPC invocation? Why would you only track the server-side portion? |
I'm not sure how client instrumentation would know it's calling a FaaS. I looked but couldn't find any examples of FaaS client instrumentation in OpenTelemetry repos. |
I agree, the shape/state of the Based on that I don't think we need a dedicated faas exception but instead use messaging/rpc exception where appropriate.
The scenario which comes to mind is https://opentelemetry.io/docs/specs/semconv/faas/aws-lambda/#api-gateway-request-proxy-lambda-tracing-active. With the most likely repo being https://github.com/open-telemetry/opentelemetry-lambda |
|
cc @open-telemetry/lambda-extension-approvers |
|
Example of client side "invoke": https://docs.aws.amazon.com/lambda/latest/dg/example_lambda_Invoke_section.html We think this is the only example of client-side knowledge of FaaS client call, and generally FaaS are just treated as HTTP/mesaging/etc endpoints. So may be ok to say "invocation" = server, and prefix with client. for the rare case, e.g.
Instead of:
And if we needed to model the AWS thing, it could be |
tylerbenson
left a comment
There was a problem hiding this comment.
Seems reasonable to me... I agree that excluding server from the name makes sense.
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
af46181
Similar to
Note: while FaaS does have a client span defined, I'm not convinced it should exist, and the metrics seem to be only about server side, and so I'm aligning the exception event with the metrics and server span.