-
Notifications
You must be signed in to change notification settings - Fork 353
Add event name and severity considerations to log-based exception events #3311
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
0ba626d
Add event name and severity considerations to log-based exceptions
lmolkova 734f60a
update to use proposed as an example
lmolkova 82ded5d
update based on new .exception events
lmolkova 7bfd630
up
lmolkova 3700018
Merge branch 'main' into exception-severity
lmolkova 96adf3b
review
lmolkova c28ece6
Merge branch 'main' into exception-severity
lmolkova c55c937
Review: TRACE and DEBUG and nitS
lmolkova a86e929
address some feedback
lmolkova 49af578
Update docs/exceptions/exceptions-logs.md
pellared befef7c
don't report artifical exceptions at all
lmolkova da13e26
Merge branch 'exception-severity' of https://github.com/lmolkova/sema…
lmolkova 81d03cc
Merge branch 'main' into exception-severity
lmolkova cc641b2
review
lmolkova 8a31d35
bring back dropped commit
lmolkova a7dc1c7
Update docs/exceptions/exceptions-logs.md
lmolkova 87d12ec
Merge branch 'main' into exception-severity
lmolkova d20a272
span context
lmolkova 8d40073
Merge branch 'exception-severity' of https://github.com/lmolkova/sema…
lmolkova ea22175
Apply suggestions from code review
lmolkova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,6 @@ | ||
| change_type: enhancement | ||
| component: exception | ||
| note: > | ||
| Improve exception event definition: add guidance on how to set event name and | ||
| severity. | ||
| issues: [3311] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.