Conversation
6198eab to
5e3c4b7
Compare
5e3c4b7 to
413bf2b
Compare
There was a problem hiding this comment.
Pull request overview
This PR adds a comprehensive migration guide to help users transition from experimental RPC semantic conventions (v1.37.0) to the upcoming stable version. The document follows established patterns from HTTP and database migration guides, providing a structured approach for instrumentation maintainers to implement backward-compatible upgrades.
Key Changes:
- Added detailed RPC migration documentation covering span attributes, metrics, and their respective changes
- Documented the
OTEL_SEMCONV_STABILITY_OPT_INenvironment variable pattern for phased rollout - Included comprehensive change tables for attribute renames, new attributes, and deprecated metrics
- Added changelog entry for the enhancement
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 7 comments.
| File | Description |
|---|---|
| docs/non-normative/rpc-migration.md | New migration guide documenting changes to RPC semantic conventions including attribute renames (e.g., rpc.system → rpc.system.name), metric name changes (e.g., rpc.server.duration → rpc.server.call.duration), unit changes (ms → s), and deprecated metrics |
| .chloggen/rpc-migration-doc.yaml | Changelog entry for the RPC migration guide enhancement |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days. |
4ad1c6f to
dc7ec75
Compare
|
Implementation issue for Java: open-telemetry/opentelemetry-java-instrumentation#15871 |
|
what is the expected behavior of span attributes with
For DB stabilization, we added all, but there is no conflict: |
|
network.protocol.name is not conditional on being different from |
|
|
Should
|
Resolves #3204
Marking as ready to start reviewing but will wait to merge until after #3223 is merged and that change incorporated.