Skip to content

pprof: add profile attribute#3078

Merged
jsuereth merged 3 commits intoopen-telemetry:mainfrom
florianl:pprof-profile
Jan 7, 2026
Merged

pprof: add profile attribute#3078
jsuereth merged 3 commits intoopen-telemetry:mainfrom
florianl:pprof-profile

Conversation

@florianl
Copy link
Member

Changes

Add pprof specific attributes to help convert pprof to OTel profiles and vice versa.

FYI @open-telemetry/profiling-approvers

Important

Pull requests acceptance are subject to the triage process as described in Issue and PR Triage Management.
PRs that do not follow the guidance above, may be automatically rejected and closed.

Merge requirement checklist

  • CONTRIBUTING.md guidelines followed.
  • Change log entry added, according to the guidelines in When to add a changelog entry.
    • If your PR does not need a change log, start the PR title with [chore]
  • Links to the prototypes or existing instrumentations (when adding or changing conventions)

Add pprof specific attributes to help convert pprof to OTel profiles and vice versa.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl moved this from Untriaged to Awaiting codeowners approval in Semantic Conventions Triage Nov 13, 2025
@thompson-tomo
Copy link
Contributor

Should these new attributes also appear on the profiles page in the compatibility section?

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@aalexand
Copy link
Member

@florianl For the default sample type and sample type order handling in the conversion, I wrote up some notes here, could you take a look?

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@github-actions
Copy link

github-actions bot commented Jan 2, 2026

This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 7 days.

@github-actions github-actions bot added the Stale label Jan 2, 2026
@florianl
Copy link
Member Author

florianl commented Jan 5, 2026

Friendly ping to @open-telemetry/specs-semconv-approvers to review and merge this proposal.

@lmolkova lmolkova moved this from Awaiting codeowners approval to Needs More Approval in Semantic Conventions Triage Jan 5, 2026
@github-actions github-actions bot removed the Stale label Jan 6, 2026
@jsuereth jsuereth added this pull request to the merge queue Jan 7, 2026
Merged via the queue into open-telemetry:main with commit b883922 Jan 7, 2026
18 checks passed
Cirilla-zmh pushed a commit to Cirilla-zmh/semantic-conventions that referenced this pull request Feb 3, 2026
Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants