[chore] Clean up Entity snippets - make sure they include identifying vs. descriptive roles#2970
Conversation
- Re-use same macros both in registry and entity snippets. - Make sure identifying/descriptive attributes show up in snippets. - Ensure warning about identifying/descriptive attributes and stability shows up in snippets.
|
WDYT about something like
vs (in the current version)
it might work similar to @joaopgrassi 's proposal for sampling-relevant attrs here |
|
@lmolkova I'd prefer to have it (a) sorted so identity is first and (b) a clear separation between identity + description. I think, going forward, it's going to be important to delineate what these mean to folks using entities. Anyone in @open-telemetry/entities-maintainers have thoughts? |
|
Also I guess we want to align the columns with #2867? |
|
@lmolkova PTAL at latest incarnation of the table - it's a blend of what you did and what I did |
thompson-tomo
left a comment
There was a problem hiding this comment.
Some general comments to tackle repeated empty lines.
Also is it still the plan to remove the resource pages as per #2327
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Co-authored-by: James Thompson <thompson.tomo@outlook.com>
Yes, with the caveat - there's a lot more urgent things to sort out first. |
|
I liked the badges 😞. Hopefully we can find a long-term solution with the html limitation with the OTel website. CC @chalin we cannot use html inside markdown tables, right? |
|
@joaopgrassi - OTel.io isn't the limitation. Here's my take on all this. IMHO:
We can fix the badge styling in OTel.io using CSS. (We could even implement an auto-rendering of badges for certain (solo) keywords like "Stable" and "Development" that might appear in tables (maybe via a special marker Thoughts? As I looked at the semconv pages on OTel.io, I just noticed that badges aren't rendering properly. I'll create an issue for that. /cc @open-telemetry/docs-maintainers |
|
Let me know if you want me to look into the badge-size issue. FYI, I'll be fixing the current bug with badge display via: |
|
@chalin AH yes, I think you're right. I couldn't emember the details and wanted to avoid breaking opentelemetry.io. Thanks for the links, so images are ok, but that gets into your other comment. I absolutely agree with what you're saying - github pages are a convenience and we need rich markup going forward. If you think this is fixable on opentelemetry.io I'm happy to defer to that. I agree these tables are already too complicated. |
Uh oh!
There was an error while loading. Please reload this page.