[chore] Desiginate event.name as obsoleted#2606
[chore] Desiginate event.name as obsoleted#2606thompson-tomo wants to merge 1 commit intoopen-telemetry:mainfrom
Conversation
|
This PR was designed to not change the definition of any attribute but rather is a documentation chore to increase consistency. Yes it might only be short lived change if the attribute is undeprecated but that is likely to take longer. |
|
I'd also rather wait to the resolution of #2597 before merging this. Let's not make extra work for ourselves if it will be brought back. |
lmolkova
left a comment
There was a problem hiding this comment.
Is there a reason behind this change? It does not seem to bring any obvious benefits.
|
There is a replacement - it's the event_name property on the proto. It's not an attribute though. |
|
Three is not a replacement attribute as we are talking about attributes. It is obsoleted as now it is not needing to be added as an attribute as the message property can be directly used. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closing per #2715 |
|
@thompson-tomo, this can be reopened per #2914 and #2913. |
Changes
This marks event.name as obsoleted rather than uncategorised,
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]