Define dynamic request attributes for Google GenAI LLM inference spans#2125
Define dynamic request attributes for Google GenAI LLM inference spans#2125michaelsafyan wants to merge 14 commits intoopen-telemetry:mainfrom
Conversation
… create a GCP-specific variants of the Gen AI documentation in support of this.
|
@lmolkova reaching back to see what the next steps are to make forward progress here... for example, do we need to wait for Weaver to resolve open-telemetry/weaver#705 before we can move forward? And do we need this PR to go in before we can submit/merge open-telemetry/opentelemetry-python-contrib#3374 ? It looks like Traceloop has some interest in iterating on the Google Gen AI SDK instrumentation (traceloop/openllmetry#2675) ... so I'm wondering if it might make sense to accelerate the merge of open-telemetry/opentelemetry-python-contrib#3374 (even with this pending) simply to reduce the chance of future merge conflicts ... I know that code tends to rot the longer it is out-of-sync. |
|
I see some yamllint errors: ... which I'm not quite sure how to fix. Before spending too much time on that, though, I want to confirm that the updated definition is acceptable. |
lmolkova
left a comment
There was a problem hiding this comment.
Left some cosmetic suggestions, LGTM otherwise
|
This LGTM once comments are addressed. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Closed as inactive. Feel free to reopen if this PR is still being worked on. |
|
reopening in case @aabmass would like to take it over |
|
This PR has been labeled as stale due to lack of activity. It will be automatically closed if there is no further activity over the next 14 days. |
|
I'm happy to take this over, address the comments and update it to include the changes to the semantic convention since then |
|
@Rima-ag sure, done! |
Fixes open-telemetry/semantic-conventions-genai#27
Changes
Defines a
gcp.gen_ai.operation.config.<key>dynamic attribute in support of Google Gen AI SDK instrumentation (see: PR 3374: include more request configuration options...). In support of this change, this also adds a Google-specific variant of the Gen AI docs. We anticipate that this will serve to enable additional documentation and Semantic Conventions for Google-specific elements beyond the dynamic request attributes being documented here.Merge requirement checklist
[chore]