-
Notifications
You must be signed in to change notification settings - Fork 353
Introduce app click events #2070
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
6ca6d44
introduce app click event semconv
breedx-splk 3642a14
add changelog item.
breedx-splk 2f30db9
fix event ids
breedx-splk a642572
Merge branch 'main' into app_click_events
breedx-splk 6cb053d
Merge branch 'main' into app_click_events
breedx-splk 56b3a03
Merge branch 'main' into app_click_events
breedx-splk dee3797
Merge branch 'main' into app_click_events
breedx-splk 3046da9
Merge branch 'main' into app_click_events
breedx-splk 06aafab
Merge branch 'main' into app_click_events
breedx-splk bd3d898
fix copypasta bug
breedx-splk 4134eaa
remove attribute table and instead link to registry
breedx-splk d1f8e9b
lint
breedx-splk 00094cb
add toc
breedx-splk 55a1e19
move attributes down
breedx-splk 9cccf9b
lint
breedx-splk d366beb
Update docs/app/app.md
breedx-splk b06c4ba
make markdown-toc
breedx-splk 8ad7997
based on client sig discussions and agreed upon guidance, change the …
breedx-splk 1ada30c
Revert "based on client sig discussions and agreed upon guidance, cha…
breedx-splk File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: app | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: Defines two new click events for the app domain | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [2070] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,88 @@ | ||
| <!--- Hugo front matter used to generate the website version of this page: | ||
| linkTitle: App | ||
| ---> | ||
|
|
||
| # App | ||
|
|
||
| **Status**: [Development][DocumentStatus] | ||
|
|
||
| This document defines events related to client-side applications | ||
| (e.g. web apps or mobile apps). | ||
|
|
||
| <!-- toc --> | ||
|
|
||
| - [Click Events](#click-events) | ||
| - [Event: `app.screen.click`](#event-appscreenclick) | ||
| - [Event: `app.widget.click`](#event-appwidgetclick) | ||
| - [Attributes](#attributes) | ||
|
|
||
| <!-- tocstop --> | ||
|
|
||
| ## Click Events | ||
|
|
||
| ### Event: `app.screen.click` | ||
|
|
||
| <!-- semconv event.app.screen.click --> | ||
| <!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/snippet.md.j2 --> | ||
| <!-- prettier-ignore-start --> | ||
| <!-- markdownlint-capture --> | ||
| <!-- markdownlint-disable --> | ||
|
|
||
| **Status:**  | ||
|
|
||
| The event name MUST be `app.screen.click`. | ||
|
|
||
| This event represents an instantaneous click on the screen of an application. | ||
|
|
||
| The `app.screen.click` event can be used to indicate that a user has clicked or tapped on the screen portion of an application. Clicks outside of an application's active area SHOULD NOT generate this event. This event does not differentiate between touch/mouse down and touch/mouse up. Implementations SHOULD give preference to generating this event at the time the click is complete, typically on touch release or mouse up. The location of the click event MUST be provided in absolute screen pixels. | ||
|
trask marked this conversation as resolved.
|
||
|
|
||
| | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | | ||
| |---|---|---|---|---|---| | ||
| | [`app.screen.coordinate.x`](/docs/attributes-registry/app.md) | int | The x (horizontal) coordinate of a screen coordinate, in screen pixels. | `0`; `131` | `Required` |  | | ||
|
breedx-splk marked this conversation as resolved.
|
||
| | [`app.screen.coordinate.y`](/docs/attributes-registry/app.md) | int | The y (vertical) component of a screen coordinate, in screen pixels. | `12`; `99` | `Required` |  | | ||
|
|
||
| <!-- markdownlint-restore --> | ||
|
lmolkova marked this conversation as resolved.
|
||
| <!-- prettier-ignore-end --> | ||
| <!-- END AUTOGENERATED TEXT --> | ||
| <!-- endsemconv --> | ||
|
|
||
| ### Event: `app.widget.click` | ||
|
|
||
| <!-- semconv event.app.widget.click --> | ||
| <!-- NOTE: THIS TEXT IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
| <!-- see templates/registry/markdown/snippet.md.j2 --> | ||
| <!-- prettier-ignore-start --> | ||
| <!-- markdownlint-capture --> | ||
| <!-- markdownlint-disable --> | ||
|
|
||
| **Status:**  | ||
|
|
||
| The event name MUST be `app.widget.click`. | ||
|
|
||
| This event indicates that an application widget has been clicked. | ||
|
|
||
| Use this event to indicate that visual application component has been clicked, typically through a user's manual interaction. | ||
|
|
||
| | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | | ||
| |---|---|---|---|---|---| | ||
| | [`app.widget.id`](/docs/attributes-registry/app.md) | string | An identifier that uniquely differentiates this widget from other widgets in the same application. [1] | `f9bc787d-ff05-48ad-90e1-fca1d46130b3`; `submit_order_1829` | `Required` |  | | ||
| | [`app.screen.coordinate.x`](/docs/attributes-registry/app.md) | int | The x (horizontal) coordinate of a screen coordinate, in screen pixels. | `0`; `131` | `Opt-In` |  | | ||
| | [`app.screen.coordinate.y`](/docs/attributes-registry/app.md) | int | The y (vertical) component of a screen coordinate, in screen pixels. | `12`; `99` | `Opt-In` |  | | ||
| | [`app.widget.name`](/docs/attributes-registry/app.md) | string | The name of an application widget. [2] | `submit`; `attack`; `Clear Cart` | `Opt-In` |  | | ||
|
|
||
| **[1] `app.widget.id`:** A widget is an application component, typically an on-screen visual GUI element. | ||
|
|
||
| **[2] `app.widget.name`:** A widget is an application component, typically an on-screen visual GUI element. | ||
|
|
||
| <!-- markdownlint-restore --> | ||
| <!-- prettier-ignore-end --> | ||
| <!-- END AUTOGENERATED TEXT --> | ||
| <!-- endsemconv --> | ||
|
|
||
| ## Attributes | ||
|
|
||
| See the [app attributes](/docs/attributes-registry/app.md) registry for all | ||
| application-related attributes that may appear on telemetry items. | ||
|
|
||
| [DocumentStatus]: https://opentelemetry.io/docs/specs/otel/document-status | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| groups: | ||
| - id: event.app.screen.click | ||
| stability: development | ||
| type: event | ||
| name: app.screen.click | ||
| brief: > | ||
| This event represents an instantaneous click on the screen of an application. | ||
| note: > | ||
| The `app.screen.click` event can be used to indicate that a user has | ||
| clicked or tapped on the screen portion of an application. Clicks | ||
| outside of an application's active area SHOULD NOT generate this event. | ||
| This event does not differentiate between touch/mouse down and | ||
| touch/mouse up. Implementations SHOULD give preference to generating | ||
| this event at the time the click is complete, typically on touch | ||
| release or mouse up. The location of the click event MUST be provided | ||
| in absolute screen pixels. | ||
| attributes: | ||
| - ref: app.screen.coordinate.x | ||
| requirement_level: required | ||
| - ref: app.screen.coordinate.y | ||
| requirement_level: required | ||
| - id: event.app.widget.click | ||
| stability: development | ||
| type: event | ||
| name: app.widget.click | ||
| brief: > | ||
| This event indicates that an application widget has been clicked. | ||
| note: > | ||
| Use this event to indicate that visual application component has been | ||
| clicked, typically through a user's manual interaction. | ||
| attributes: | ||
| - ref: app.widget.id | ||
| requirement_level: required | ||
| - ref: app.widget.name | ||
| requirement_level: opt_in | ||
| - ref: app.screen.coordinate.x | ||
| requirement_level: opt_in | ||
| - ref: app.screen.coordinate.y | ||
| requirement_level: opt_in |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.