-
Notifications
You must be signed in to change notification settings - Fork 278
Introduce request error type attribute #205
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arminru
merged 13 commits into
open-telemetry:main
from
lmolkova:http-request-error-reason
Sep 11, 2023
Merged
Changes from 11 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4d21271
error.description and http updates
17194cc
nits
12d24bd
review comments and error.id
0caff69
remove empty error.id
60c85fe
same note on spans and metrics
62f904d
review p2
7563f45
Apply suggestions from code review
7b49a0b
regenerate mds
2eab98b
Rename to error.type
trask 655a9e4
error type on client metrics
aa2dd45
rephrase error.type to clarify that instr can recode exceptions on to…
31b0b4a
Merge branch 'main' into http-request-error-reason
arminru 9ee6db9
Merge branch 'main' into http-request-error-reason
arminru File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| groups: | ||
| - id: error | ||
| type: attribute_group | ||
| prefix: error | ||
| brief: > | ||
| This document defines the shared attributes used to | ||
| report an error. | ||
| attributes: | ||
| - id: type | ||
| brief: 'Describes a class of error the operation ended with.' | ||
| type: | ||
| allow_custom_values: true | ||
| members: | ||
| - id: other | ||
| value: "_OTHER" | ||
lmolkova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| brief: 'A fallback error value to be used when the instrumentation does not define a custom value for it.' | ||
| examples: ['timeout', 'java.net.UnknownHostException', 'server_certificate_invalid', '500'] | ||
| note: | | ||
| The `error.type` SHOULD be predictable and SHOULD have low cardinality. | ||
| Instrumentations SHOULD document the list of errors they report. | ||
|
|
||
| The cardinality of `error.type` within one instrumentation library SHOULD be low, but | ||
| telemetry consumers that aggregate data from multiple instrumentation libraries and applications | ||
| should be prepared for `error.type` to have high cardinality at query time, when no | ||
| additional filters are applied. | ||
lmolkova marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| If the operation has completed successfully, instrumentations SHOULD NOT set `error.type`. | ||
|
|
||
| If a specific domain defines its own set of error codes (such as HTTP or gRPC status codes), | ||
| it's RECOMMENDED to use a domain-specific attribute and also set `error.type` to capture | ||
| all errors, regardless of whether they are defined within the domain-specific set or not. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.