Skip to content

Database: mention metrics in system-specific docs#1779

Merged
trask merged 6 commits intoopen-telemetry:mainfrom
lmolkova:database-add-metrics-to-systems
Jan 24, 2025
Merged

Database: mention metrics in system-specific docs#1779
trask merged 6 commits intoopen-telemetry:mainfrom
lmolkova:database-add-metrics-to-systems

Conversation

@lmolkova
Copy link
Copy Markdown
Member

Fixes #1447

Add Spans and Metrics section to each of system-specific DB conventions, add TOC and clean up minor things

Merge requirement checklist

@lmolkova lmolkova requested review from a team as code owners January 21, 2025 01:25
@lmolkova lmolkova requested a review from a team as a code owner January 21, 2025 01:29
Comment thread docs/database/cosmosdb.md Outdated
Comment thread docs/database/hbase.md Outdated
Comment thread docs/database/mssql.md Outdated
Comment thread .chloggen/1779.yaml Outdated
Co-authored-by: Trask Stalnaker <trask.stalnaker@gmail.com>
@github-actions github-actions Bot added the enhancement New feature or request label Jan 23, 2025
@trask trask enabled auto-merge (squash) January 24, 2025 03:21
@trask trask merged commit cc780be into open-telemetry:main Jan 24, 2025
@sincejune
Copy link
Copy Markdown
Contributor

May I ask why do we use db.type for metrics while db.type.name for spans?


Also raised #1914 for changing db.type value for mssql.

@trask
Copy link
Copy Markdown
Member

trask commented Feb 18, 2025

hi @sincejune, thanks for reporting this! it looks like we missed a few places when renaming db.system to db.system.name. and thanks for sending #1914!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Database semconv: explicitly call out the status of metrics for individual systems

4 participants