Don't render deprecated enum members#1764
Merged
lmolkova merged 2 commits intoopen-telemetry:mainfrom Jan 22, 2025
Merged
Conversation
lmolkova
commented
Jan 18, 2025
3 tasks
trask
approved these changes
Jan 18, 2025
arminru
approved these changes
Jan 22, 2025
Member
arminru
left a comment
There was a problem hiding this comment.
I think it's fine to not render them and by keeping them in YAML it also prevents people from accidentally re-introducing them.
Alternatively we could also render them in a separate section or move them to the end of the table, but this might just bulk up markdown further.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this was the intention - I don't see a reason why we want to render them (they should remain in yaml for history and codegen though). Plus it results in weird things like this #1757 (comment)
Merge requirement checklist
[chore]