Skip to content

model/profile: add frame.type for Erlang#1735

Merged
joaopgrassi merged 4 commits intoopen-telemetry:mainfrom
florianl:profile-frame-type-beam
Jan 23, 2025
Merged

model/profile: add frame.type for Erlang#1735
joaopgrassi merged 4 commits intoopen-telemetry:mainfrom
florianl:profile-frame-type-beam

Conversation

@florianl
Copy link
Copy Markdown
Member

Changes

Please provide a brief description of the changes here.

FYI @open-telemetry/profiling-maintainers

Merge requirement checklist

Extend the list of known frame types with a value for Erlang.

Signed-off-by: Florian Lehner <florian.lehner@elastic.co>
@florianl florianl force-pushed the profile-frame-type-beam branch from d2d8a1b to 542d56a Compare January 10, 2025 10:09
Comment thread model/profile/registry.yaml
@trask
Copy link
Copy Markdown
Member

trask commented Jan 10, 2025

cc @open-telemetry/profiling-approvers

Comment thread .chloggen/profile-frame-type-beam.yaml Outdated
Comment thread model/profile/registry.yaml
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
@trask
Copy link
Copy Markdown
Member

trask commented Jan 21, 2025

moving to draft and back, to see if that will give profiling approvers green checkmark

@trask trask marked this pull request as draft January 21, 2025 01:10
@trask trask marked this pull request as ready for review January 21, 2025 01:10
@trask
Copy link
Copy Markdown
Member

trask commented Jan 21, 2025

one more try (closing and re-opening) 🤷‍♂️

@trask trask closed this Jan 21, 2025
@trask trask reopened this Jan 21, 2025
@trask
Copy link
Copy Markdown
Member

trask commented Jan 21, 2025

ah, will fix...

Unknown owner on line 114: make sure the team @open-telemetry/profiling-approvers exists, is publicly visible, and has write access to the repository
…metry/specs-semconv-approvers @open-telemetry/profiling-approvers

@lmolkova lmolkova requested a review from a team as a code owner January 23, 2025 03:05
@github-actions github-actions Bot added the enhancement New feature or request label Jan 23, 2025
@lmolkova lmolkova added this to the v1.30.0 milestone Jan 23, 2025
@joaopgrassi joaopgrassi merged commit b0f3969 into open-telemetry:main Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

7 participants