-
Notifications
You must be signed in to change notification settings - Fork 353
add origin_referrer_url and origin_url to the process attribute
#1517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
cf92b34
3caaa00
4ad5fdf
2d8178f
356c110
5bac30a
c24ce50
f29e029
b69b641
df6bc22
0856695
587f70b
6e52941
27a733d
d9e9f64
7bb2a3d
5e2741f
d9309b8
ad0f670
6bb0883
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| # Use this changelog template to create an entry for release notes. | ||
| # | ||
| # If your change doesn't affect end users you should instead start | ||
| # your pull request title with [chore] or use the "Skip Changelog" label. | ||
|
|
||
| # One of 'breaking', 'deprecation', 'new_component', 'enhancement', 'bug_fix' | ||
| change_type: enhancement | ||
|
|
||
| # The name of the area of concern in the attributes-registry, (e.g. http, cloud, db) | ||
| component: process | ||
|
|
||
| # A brief description of the change. Surround your text with quotes ("") if it needs to start with a backtick (`). | ||
| note: add process.executable.origin_referrer_url and process.executable.origin_url | ||
|
|
||
| # Mandatory: One or more tracking issues related to the change. You can use the PR number here if no issue exists. | ||
| # The values here must be integers. | ||
| issues: [1517] | ||
|
|
||
| # (Optional) One or more lines of additional information to render under the primary note. | ||
| # These lines will be padded with 2 spaces and then inserted directly into the document. | ||
| # Use pipe (|) for multiline entries. | ||
| subtext: | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -76,6 +76,30 @@ groups: | |
| be set to the target of `proc/[pid]/exe`. On Windows, can be set to the | ||
| result of `GetProcessImageFileNameW`. | ||
| examples: ['/usr/bin/cmd/otelcol'] | ||
| - id: process.executable.origin_referrer_url | ||
| type: string | ||
| stability: experimental | ||
| brief: > | ||
| The URL of the webpage that linked to the process's executable file. | ||
| note: > | ||
| This information comes from metadata or alternate data streams linked to the process's executable file. | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Non-blocking, can be merged without resolving this unless there's a good answer. @open-telemetry/specs-semconv-maintainers is there a better way to specify a note like this in the YAML? This results in two separate identical notes being generated in the markdown. A way to make one note about this that could be linked by both attributes would be nice, but as far as I know there isn't a way to do that right?
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. there is no way to do this currently afaik, because we are not linking notes, it happens automatically |
||
| `process.executable.origin_url` represents the URL from which the file was downloaded, and | ||
| `process.executable.origin_referrer_url` indicates the URL of the page where that URL was listed. | ||
| There may be cases where both `process.executable.origin_url` and `process.executable.origin_referrer_url` | ||
| exist, or only one of them is present. Note that the URL itself may contain sensitive information. | ||
| examples: ['http://example.com/article1.html'] | ||
| - id: process.executable.origin_url | ||
| type: string | ||
| stability: experimental | ||
| brief: > | ||
| The URL where the process's executable file is hosted. | ||
| note: > | ||
| This information comes from metadata or alternate data streams linked to the process's executable file. | ||
| `process.executable.origin_url` represents the URL from which the file was downloaded, and | ||
| `process.executable.origin_referrer_url` indicates the URL of the page where that URL was listed. | ||
| There may be cases where both `process.executable.origin_url` and `process.executable.origin_referrer_url` | ||
| exist, or only one of them is present. Note that the URL itself may contain sensitive information. | ||
| examples: ['http://example.com/files/example.exe'] | ||
| - id: process.command | ||
| type: string | ||
| stability: experimental | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are those necessary - could similar
fileattributes being introduced in #1430 be used instead? if not, why?