Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Define semantic convention group and mixed stability rules #1472

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

lmolkova
Copy link
Contributor

Fixes #906.

Related: #1423

Key points:

  • Allow stable groups with experimental attributes (as opt-in)
  • Document some rules around it

Merge requirement checklist

**Experimental groups:**

- MAY add or remove references to stable or experimental attributes
- MAY change requirement level and other properties of attribute references
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subject to more specific rules, e.g. metric groups where you CANNOT change requirement_level without it being a breaking change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is allow-list for experimental groups - breaking, but allowed

Copy link
Contributor Author

@lmolkova lmolkova Oct 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I initially called it out in the stable group list below, but then decided that stable groups + stable attributes guarantees would belong in the https://github.com/open-telemetry/opentelemetry-specification/blob/0a78571045ca1dca48621c9648ec3c832c3c541c/specification/versioning-and-stability.md?plain=1#L217. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should there be any attributes marked as stable inside of experimental conventions?
2 participants