-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a datacenter resource. #1413
base: main
Are you sure you want to change the base?
Add a datacenter resource. #1413
Conversation
1ae444e
to
eb6b348
Compare
|
||
# Datacenter | ||
|
||
## Datacenter Attributes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have tooling to autogenerate markdown, you should use <!-- semconv datacenter -->
here for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I used the automated tool. I wonder if because the name was missing this resulted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well I found out what the issue was, perhaps I missed it in my reading of the various documentation, but I didn't see any mention that you need to first manually create a file which has the reference which you are mentioning, and then it will replace the contents between. I can understand the use, but it's not exactly clear as a first time user of the weaver tool.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jsuereth am i missing something
model/datacenter/resources.yaml
Outdated
@@ -0,0 +1,15 @@ | |||
groups: | |||
- id: datacenter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This needs a name
field, set it to datacenter
for now
2369cb4
to
01b85e3
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
This is a bit of an anti pattern ... stale because i haven't received a review? Also check failure is unrelated to this change. |
The purpose of this is to allow for people running in a hybrid environment.
10b7e40
to
48cfd1c
Compare
<!-- NOTE: THIS FILE IS AUTOGENERATED. DO NOT EDIT BY HAND. --> | ||
<!-- see templates/registry/markdown/attribute_namespace.md.j2 --> | ||
|
||
# DC |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure it is a good idea to use the abbreviation here. I'd be more inclined to go with "Data Center" instead.
The purpose of this is to allow for people running in a hybrid environment.
Relates #1409
Changes
Please provide a brief description of the changes here.
Note: if the PR is touching an area that is not listed in the existing areas, or the area does not have sufficient domain experts coverage, the PR might be tagged as experts needed and move slowly until experts are identified.
Merge requirement checklist
[chore]