Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database semconv stability migration guide #1090

Merged
merged 7 commits into from
Oct 10, 2024

Conversation

trask
Copy link
Member

@trask trask commented May 29, 2024

Fixes #1022

Changes

Documents the changes between experimental database semantic conventions and the (to-be) stable database semantic conventions.

@trask
Copy link
Member Author

trask commented May 31, 2024

TODO: add section to document changes to experimental metrics also

@maryliag
Copy link
Contributor

TODO: add section to document changes to experimental metrics also

example: db.client.connections.usage -> db.client.connection.count

@trask trask added the Skip Changelog Label to skip the changelog check label Jun 6, 2024
@trask trask marked this pull request as ready for review July 10, 2024 22:18
@trask trask requested review from a team July 10, 2024 22:18
@trask trask marked this pull request as draft July 10, 2024 22:20
@trask
Copy link
Member Author

trask commented Jul 10, 2024

I'm thinking we should wait to merge this until after stability, just to avoid confusion in case there are any last-minute changes.

But please review it and leave comments / suggestions / questions.

@lmolkova lmolkova added the never stale PRs marked with this label will be never staled and automatically closed label Jul 11, 2024
@trask trask force-pushed the migration-guide branch 2 times, most recently from 5e04728 to 6c9bd33 Compare October 1, 2024 01:02
@TylerHelmuth
Copy link
Member

Saw that Database semconv was getting ready to mark stable and I love that this has existed along side it ❤️

@trask trask marked this pull request as ready for review October 8, 2024 18:19
@trask trask requested review from a team as code owners October 8, 2024 18:19
@trask
Copy link
Member Author

trask commented Oct 8, 2024

@open-telemetry/specs-semconv-maintainers the policy violations seem unrelated to this PR:

Diagnostic report:

Violation: Resource 'service' cannot remove required/recommended attributes (missing '{"service.name", "service.version"}')
  - Category         : backward_compatibility
  - Type             : semconv_attribute
  - SemConv group    : service
  - SemConv attribute: 
  - Provenance: /home/weaver/source

Violation: Resource 'telemetry.sdk' cannot remove required/recommended attributes (missing '{"telemetry.sdk.language", "telemetry.sdk.name", "telemetry.sdk.version"}')
  - Category         : backward_compatibility
  - Type             : semconv_attribute
  - SemConv group    : telemetry.sdk
  - SemConv attribute: 
  - Provenance: /home/weaver/source

@lmolkova lmolkova merged commit 29da85e into open-telemetry:main Oct 10, 2024
13 of 14 checks passed
@trask trask deleted the migration-guide branch October 14, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
never stale PRs marked with this label will be never staled and automatically closed Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Database: write migration guide for (to-be) stable semconv
7 participants