Handle mix of stable and unstable enum values#220
Closed
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:handle-unstable-enums
Closed
Handle mix of stable and unstable enum values#220trask wants to merge 1 commit intoopen-telemetry:mainfrom trask:handle-unstable-enums
trask wants to merge 1 commit intoopen-telemetry:mainfrom
trask:handle-unstable-enums
Conversation
trask
commented
May 15, 2025
Comment on lines
-93
to
-95
| /** QUIC */ | ||
| public static final String QUIC = "quic"; | ||
|
|
Member
Author
There was a problem hiding this comment.
oops, this has been around for a while 🙈
@jack-berg any thoughts? I'm guessing we need to wedge it back into the stable definition here somehow?
There was a problem hiding this comment.
open-telemetry/opentelemetry-js#5690 (comment) is the equivalent open question for the JS semconv package
Member
Author
There was a problem hiding this comment.
trask
changed the title
Member
Author
|
Closing, need to merge this into #208 in order to pick up the stability change to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing #217 (comment) before upgrading to semconv 1.33.0.