This repository has been archived by the owner on Dec 6, 2024. It is now read-only.
Change 0002 Remove SpanData status to approved #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bg451
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
songy23,
tedsuo and
yurishkuro
as code owners
songy23
approved these changes
Aug 16, 2019
reyang
approved these changes
Aug 16, 2019
carlosalberto
approved these changes
Aug 16, 2019
It seems like that is not always the case, but for this specific RFC, it is ;) |
|
Yes based on previous discussions that is not the case, for this I think we are good. |
bogdandrutu
approved these changes
Aug 16, 2019
|
I am waiting for 1 more approval before merging. |
|
Could the PR title be changed to include the name of the RFC? That way it might get the right people look over that quicker (probably doesn't matter anymore for this PR now, but for the future...). |
iredelmeier
approved these changes
Aug 19, 2019
bg451
changed the title
|
We have 5/10 approvers, do we need majority for this to merge (>5)? |
bhs
approved these changes
Aug 19, 2019
There was a problem hiding this comment.
@bogdandrutu I'm not sure what the requirements are around majorities, but don't let me hold you back! :)
Oberon00
pushed a commit
to dynatrace-oss-contrib/oteps
that referenced
this pull request
Sep 16, 2019
* distributed tracing terminology * added comment * addressed feedback
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 23, 2024
carlosalberto
pushed a commit
to carlosalberto/oteps
that referenced
this pull request
Oct 30, 2024
carlosalberto
pushed a commit
to open-telemetry/opentelemetry-specification
that referenced
this pull request
Nov 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an rfc is merged, does that mean it's approved? cc @iredelmeier