Skip to content

[otel-arrow/exporter] Remove call to SetSpanSizeAttributes; make Count call unconditional #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jmacd wants to merge 1 commit into from
Closed

[otel-arrow/exporter] Remove call to SetSpanSizeAttributes; make Count call unconditional #203

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions collector/exporter/otelarrowexporter/internal/arrow/stream.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -351,13 +351,10 @@ func (s *Stream) encodeAndSend(wri writeItem, hdrsBuf *bytes.Buffer, hdrsEnc *hp
// unreliable for arrow transport, so we instrument it
// directly here. Only the primary direction of transport
// is instrumented this way.
if wri.uncompSize != 0 {
var sized netstats.SizesStruct
sized.Method = s.method
sized.Length = int64(wri.uncompSize)
s.netReporter.CountSend(ctx, sized)
s.netReporter.SetSpanSizeAttributes(ctx, sized)
}
var sized netstats.SizesStruct
sized.Method = s.method
sized.Length = int64(wri.uncompSize)
s.netReporter.CountSend(ctx, sized)

if err := s.client.Send(batch); err != nil {
// The error will be sent to errCh during cleanup for this stream.
Expand Down