This repository has been archived by the owner on Nov 7, 2023. It is now read-only.
Support encoding optional headers in the OTLP-Arrow exporter #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 12, 2023 15:59
… testbed authors)
…lues from client.Info.Metadata
|
The exporter has been updated with a new configuration struct named |
|
@ptal especially @paivagustavo, thanks! |
lquerel
approved these changes
Jan 13, 2023
kristinapathak
approved these changes
Jan 13, 2023
|
PTAL. I have updated the exporter to locate the Auth extension and use its PerRPCCredentials().GetRequestMetadata() to get per-request headers. All the existing mechanisms work at the stream level, and I will update the Receiver PR to correctly merge the incoming context (from the stream) w/ the per-request metadata (from the arrow batch). |
paivagustavo
approved these changes
Jan 19, 2023
added 2 commits
January 19, 2023 10:58
…ollector into jmacd/exp_hpack
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This exports the result returned by the Auth extensions'
credentials.PerRPCCredentialsinterface if present and exports it with the Arrow batch using the new optional bytes field added here: f5/otel-arrow-adapter#85. This matches the behavior of the Receiver in #34. The problem about Auth is described in open-telemetry/opentelemetry-collector#6965.Unrelated cleanup. While working on the testbed, I noticed it is helpful if the Settings type is exported, not an internal package. This moves the ArrowSettings up two levels.
Part of #33