Skip to content

docs(obi): document trace attribute selection#9887

Merged
vitorvasc merged 3 commits into
open-telemetry:mainfrom
NameHaibinZhang:docs/obi-trace-attribute-selection
May 13, 2026
Merged

docs(obi): document trace attribute selection#9887
vitorvasc merged 3 commits into
open-telemetry:mainfrom
NameHaibinZhang:docs/obi-trace-attribute-selection

Conversation

@NameHaibinZhang

Copy link
Copy Markdown
Member

Description

Document the traces key under attributes.select and specifically the db.response.error configuration flag for OBI.

This user-facing documentation was originally proposed in open-telemetry/opentelemetry-ebpf-instrumentation#2086 but per reviewer feedback, it belongs in the official OBI documentation here rather than in the project's internal devdocs.

Changes

  • Added "Trace selection" section to the metrics-traces-attributes configuration page
  • Documented db.response.error behavior (default vs enabled)
  • Explained that enabling this option affects span.status.message, not a separate attribute

Related

Add documentation for the traces key under attributes.select, with
detailed explanation of db.response.error behavior.

Related: open-telemetry/opentelemetry-ebpf-instrumentation#2076
@NameHaibinZhang NameHaibinZhang requested a review from a team as a code owner May 12, 2026 09:59
@otelbot-docs otelbot-docs Bot requested a review from a team May 12, 2026 09:59
@otelbot-docs otelbot-docs Bot added the missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer label May 12, 2026
@otelbot-docs otelbot-docs Bot added the missing:sig-approval Co-owning SIG didn't provide an approval label May 12, 2026

@grcevski grcevski left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@otelbot-docs otelbot-docs Bot removed the missing:sig-approval Co-owning SIG didn't provide an approval label May 12, 2026
@otelbot-docs otelbot-docs Bot requested a review from a team May 13, 2026 01:55
@vitorvasc vitorvasc requested a review from Copilot May 13, 2026 09:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Note

Copilot was unable to run its full agentic suite in this review.

This PR updates OBI’s user-facing documentation to explain how to select trace-related optional attributes via attributes.select.traces, with a focus on the db.response.error configuration flag and its effect on span.status.message.

Changes:

  • Added a new “Trace selection” section describing the attributes.select.traces key and its purpose.
  • Documented db.response.error default vs enabled behavior and clarified it affects span.status.message.
  • Added a YAML example showing how to include trace options like db.query.text and db.response.error.

@vitorvasc vitorvasc added this pull request to the merge queue May 13, 2026
@otelbot-docs otelbot-docs Bot added ready-to-be-merged This PR is ready to be merged by a maintainer and removed missing:docs-approval Co-owning SIG has provided approval, PR needs approval from docs maintainer labels May 13, 2026
Merged via the queue into open-telemetry:main with commit 9afd426 May 13, 2026
28 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-to-be-merged This PR is ready to be merged by a maintainer sig:obi

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Document the functionality of db.response.error

4 participants