Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JS docs: path rename getting_started to getting-started #841

Merged
merged 3 commits into from
Oct 22, 2021
Merged

JS docs: path rename getting_started to getting-started #841

merged 3 commits into from
Oct 22, 2021

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 18, 2021 •
edited
Loading

@chalin chalin requested review from dyladan, austinlparker and a team October 18, 2021 18:56
@chalin chalin mentioned this pull request Oct 18, 2021
Open
12 tasks
@chalin chalin force-pushed the chalin-js-getting-started-kebab-case-2021-10-18 branch from 4636419 to c793658 Compare October 20, 2021 13:11
@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

Friendly ping to @dyladan @open-telemetry/javascript-approvers

@chalin chalin mentioned this pull request Oct 21, 2021
Closed
16 tasks
@chalin chalin requested a review from obecny October 21, 2021 17:14
@chalin
Copy link
Contributor Author

chalin commented Oct 21, 2021

Thanks for the feedback @obecny. I've incorporated your copyedit. The other comments are marked as resolved. PTAL

@chalin chalin force-pushed the chalin-js-getting-started-kebab-case-2021-10-18 branch from 0504e4a to 1e2ead4 Compare October 21, 2021 18:37
obecny
obecny approved these changes Oct 21, 2021
View reviewed changes
Copy link
Member

@obecny obecny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chalin chalin merged commit ce8607f into open-telemetry:main Oct 22, 2021
@chalin chalin deleted the chalin-js-getting-started-kebab-case-2021-10-18 branch October 22, 2021 14:10
@chalin chalin mentioned this pull request Oct 22, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@obecny obecny obecny approved these changes

@dyladan dyladan Awaiting requested review from dyladan

@austinlparker austinlparker Awaiting requested review from austinlparker

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalin @obecny