Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the default port for OLTP gRPC in Documentation Collector Configuration #576

Closed
wants to merge 1 commit into from

Conversation

hughluo
Copy link

@hughluo hughluo commented May 12, 2021

4317 is the default port for OLTP gRPC now, as open-telemetry/opentelemetry-specification#1221

@hughluo hughluo requested a review from a team May 12, 2021 15:08
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 12, 2021

CLA Signed

The committers are authorized under a signed CLA.

@shelbyspees
Copy link
Contributor

Thanks for catching this! We're actually changing how we manage docs for the collector. We want the source of truth for collector docs to live in the collector repo. This PR should already have your changes: open-telemetry/opentelemetry-collector#2839

Once that PR is merged, a separate (new) PR will be opened here to mirror the changes. Can you help us get #2839 merged?

@shelbyspees
Copy link
Contributor

Closing because this is handled in open-telemetry/opentelemetry-collector#2839

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants