Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docsy update + Reenable RSS for blog index and navigation pages #3780

Merged
merged 3 commits into from
Jan 15, 2024

Conversation

@chalin chalin requested review from a team January 15, 2024 17:13
@chalin chalin force-pushed the chalin-im-rss-for-blog-2024-01-15 branch from d95bac6 to 59c9a40 Compare January 15, 2024 17:26
@chalin
Copy link
Contributor Author

chalin commented Jan 15, 2024

The link check is failing due to an issue with Docsy. I'll file an issue and report back here. Marking as DRAFT in the meantime.

@chalin chalin marked this pull request as draft January 15, 2024 17:38
@chalin
Copy link
Contributor Author

chalin commented Jan 15, 2024

@chalin chalin force-pushed the chalin-im-rss-for-blog-2024-01-15 branch from 59c9a40 to ad35a40 Compare January 15, 2024 20:32
@chalin chalin marked this pull request as ready for review January 15, 2024 20:34
@chalin chalin changed the title Reenable RSS for blog index and navigation pages Doccsy update + Reenable RSS for blog index and navigation pages Jan 15, 2024
@chalin chalin changed the title Doccsy update + Reenable RSS for blog index and navigation pages Docsy update + Reenable RSS for blog index and navigation pages Jan 15, 2024
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@chalin
Copy link
Contributor Author

chalin commented Jan 15, 2024

Thanks, I just noticed that the RSS button isn't showing up in blog section pages. Let me fix that.

@chalin chalin marked this pull request as draft January 15, 2024 20:42
@chalin chalin marked this pull request as ready for review January 15, 2024 20:52
@chalin
Copy link
Contributor Author

chalin commented Jan 15, 2024

Ok, the RSS-feed button is there where we need it now:

image

Merging ✨

@chalin chalin merged commit ea8472f into open-telemetry:main Jan 15, 2024
14 checks passed
@chalin chalin deleted the chalin-im-rss-for-blog-2024-01-15 branch January 15, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RSS for website blog
2 participants