-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docsy update + Reenable RSS for blog index and navigation pages #3780
Merged
chalin
merged 3 commits into
open-telemetry:main
from
chalin:chalin-im-rss-for-blog-2024-01-15
Jan 15, 2024
Merged
Docsy update + Reenable RSS for blog index and navigation pages #3780
chalin
merged 3 commits into
open-telemetry:main
from
chalin:chalin-im-rss-for-blog-2024-01-15
Jan 15, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
chalin
commented
Jan 15, 2024
•
edited
Loading
edited
- Fixes RSS for website blog #3740
- Preview:
- https://deploy-preview-3780--opentelemetry.netlify.app/blog/
- https://deploy-preview-3780--opentelemetry.netlify.app/blog/index.xml
- https://deploy-preview-3780--opentelemetry.netlify.app/blog/page/4/
chalin
force-pushed
the
chalin-im-rss-for-blog-2024-01-15
branch
from
January 15, 2024 17:26
d95bac6
to
59c9a40
Compare
The link check is failing due to an issue with Docsy. I'll file an issue and report back here. Marking as DRAFT in the meantime. |
chalin
force-pushed
the
chalin-im-rss-for-blog-2024-01-15
branch
from
January 15, 2024 20:32
59c9a40
to
ad35a40
Compare
chalin
changed the title
Reenable RSS for blog index and navigation pages
Doccsy update + Reenable RSS for blog index and navigation pages
Jan 15, 2024
chalin
changed the title
Doccsy update + Reenable RSS for blog index and navigation pages
Docsy update + Reenable RSS for blog index and navigation pages
Jan 15, 2024
svrnm
approved these changes
Jan 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
Thanks, I just noticed that the RSS button isn't showing up in blog section pages. Let me fix that. |
This was referenced Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.