-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add page for JS benchmarks #3342
Conversation
@chalin could you take a look at the errors please? |
In this case you can look at the logs to see what failed, an |
@cartermp It looks like the spelling is failing on words that are part of the JS code. Is there a way to bypass that? |
Hrm. That should have fixed the spelling thing. Ugh, sorry. In the yaml metadata at the top of the file, you can add:
|
99b4ff3
to
d8cd043
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, only a minor change request.
Since this is the second benchmark page we should consider moving the CSS to a central place for that (maybe that also works for the JS piece?), not necessarily a part of this PR, but let's have a follow up issue
The Javascript SDK now has microbenchmark tests that are automatically run on every push to main. The results are currently published at https://open-telemetry.github.io/opentelemetry-js/benchmarks/.
This PR adds a page here with the same results. This is similar to what has already been done for the Collector load tests.
https://opentelemetry.io/docs/collector/benchmarks/