Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page for JS benchmarks #3342

Merged
merged 7 commits into from
Oct 4, 2023

Conversation

martinkuba
Copy link
Contributor

The Javascript SDK now has microbenchmark tests that are automatically run on every push to main. The results are currently published at https://open-telemetry.github.io/opentelemetry-js/benchmarks/.

This PR adds a page here with the same results. This is similar to what has already been done for the Collector load tests.
https://opentelemetry.io/docs/collector/benchmarks/

@martinkuba martinkuba marked this pull request as ready for review October 3, 2023 17:05
@martinkuba martinkuba requested review from a team October 3, 2023 17:05
@cartersocha
Copy link
Contributor

@chalin could you take a look at the errors please?

@cartermp
Copy link
Contributor

cartermp commented Oct 3, 2023

In this case you can look at the logs to see what failed, an npm run fix should take care of it.

@martinkuba
Copy link
Contributor Author

@cartermp It looks like the spelling is failing on words that are part of the JS code. Is there a way to bypass that?

@cartermp
Copy link
Contributor

cartermp commented Oct 3, 2023

Hrm. That should have fixed the spelling thing. Ugh, sorry.

In the yaml metadata at the top of the file, you can add:

cSpell:ignore: rrggbbaa Elems

Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, only a minor change request.

Since this is the second benchmark page we should consider moving the CSS to a central place for that (maybe that also works for the JS piece?), not necessarily a part of this PR, but let's have a follow up issue

content/en/docs/instrumentation/js/benchmarks.md Outdated Show resolved Hide resolved
@cartermp cartermp merged commit b9b64bc into open-telemetry:main Oct 4, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants