-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Demo] Add logs description for recommendation service #2951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mviitane
force-pushed
the
demo_docs_for_logs
branch
from
June 30, 2023 11:06
3554dc8
to
ec3e601
Compare
chalin
reviewed
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See inline comments, thanks.
chalin
force-pushed
the
demo_docs_for_logs
branch
from
June 30, 2023 11:16
ec3e601
to
4a4cc57
Compare
mviitane
force-pushed
the
demo_docs_for_logs
branch
from
June 30, 2023 11:56
52f3897
to
de42fd8
Compare
Explain how logs are being used in the recommendation service Related to open-telemetry#2521
chalin
force-pushed
the
demo_docs_for_logs
branch
from
June 30, 2023 12:15
a3c72dc
to
d9ac7f7
Compare
chalin
approved these changes
Jun 30, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
FYI, I created the following issue for the code-block indentation cleanup: |
svrnm
approved these changes
Jun 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain how logs are being used in the recommendation service
Related to #2521
Preview: https://deploy-preview-2951--opentelemetry.netlify.app/docs/demo/services/recommendation/#logs