-
Notifications
You must be signed in to change notification settings - Fork 896
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define Propagation-only Span to simplify active Span logic in Context. #994
Define Propagation-only Span to simplify active Span logic in Context. #994
Conversation
Co-authored-by: Christian Neumüller <[email protected]>
Co-authored-by: Christian Neumüller <[email protected]>
@Oberon00 @bogdandrutu @mwear Feedback applied. Please review ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "Note: MUST" thing should be cleared up, but approving in advance.
Renamed to |
|
||
The API MUST provide an operation for wrapping a `SpanContext` with an object | ||
implementing the `Span` interface. This is done in order to expose a `SpanContext` | ||
as a `Span` in operations such as in-process `Span` propagation. | ||
|
||
If a new type is required for supporting this operation, it SHOULD be named `PropagatorOnlySpan`. | ||
If a new type is required for supporting this operation, it SHOULD be named `PropagatedSpan`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please decide between "Propagated Span" and "PropagatedSpan"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Propagated Span is a concept, PropagatedSpan is the name (as Ruby does not need to expose it).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would think it's cleaner if we named the concepted PropagatedSpan too, but this is only an nipick anyway (I approved the PR)
… Context. (open-telemetry#994)" This reverts commit d14c9b7.
open-telemetry#994) * Define DefaultSpan to simplify active Span in Context. * Update CHANGELOG. * Update specification/trace/api.md Co-authored-by: Christian Neumüller <[email protected]> * Update specification/trace/api.md Co-authored-by: Christian Neumüller <[email protected]> * Apply feedback. * Specify the SDK must not override it. * Update CHANGELOG. * Rename to PropagatedSpan. * More feedback. Co-authored-by: Christian Neumüller <[email protected]>
Fixes #949
Changes
Define the notion of a
PropagatedSpan
, which wraps aSpanContext
, and can be leveraged to simplify the activeSpan
logic when detecting the parentSpan
in a givenContext
(so we don't have to store aSpan
and aSpanContext
inContext
).(Observe I tried to keep it as simple as possible in order to expedite this PR as much as possible ;) )