-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add description of TraceState operations #905
Conversation
Co-authored-by: Christian Neumüller <[email protected]>
Co-authored-by: Armin Ruech <[email protected]>
Points of W3C-validation need to be decided, #905 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that as @anuraaga suggested in #875 (comment) an alternative design would be to replace TraceState with a
|
It may be so, indeed. To avoid confusion: I still think this PR is useful for clarifying current state of the API and should be merged. I doubt we decide on removing TraceState completely very soon :) |
The alternative approach would not be removing TraceState, it would just move it from a first-class member of SpanContext to being implemented with that more generic |
I think this PR makes things better. Switching to map may be a separate discussion. The worst things about the map is that it is looses the order which is critical for the specification. This is why I wouldn't suggest to jump into this discussion in this PR |
@iNikem I will let this PR sit for some time for cool off period for new comments. Otherwise it looks good and will be merged if not objections received by tomorrow PT |
There are ordered maps, but my suggestion would anyway be to have the current W3C tracestate as a single unparsed string under a single key in that map.
Right, this discussion is already going on at #875 (comment) |
@SergeyKanzhelev can we merge? :) |
* Add description of TraceState operations * Apply suggestions from code review Co-authored-by: Christian Neumüller <[email protected]> * Apply suggestions from code review Co-authored-by: Armin Ruech <[email protected]> * Add validation requirement * Fix error handling Co-authored-by: Christian Neumüller <[email protected]> Co-authored-by: Armin Ruech <[email protected]> Co-authored-by: Sergey Kanzhelev <[email protected]>
Fixes #759
Changes
Add description of TraceState operations.