Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instrumentation library synonym #612

Merged
merged 3 commits into from
May 19, 2020

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented May 18, 2020

@@ -33,7 +33,7 @@ if it has built-in OpenTelemetry instrumentation.

Example: `io.opentelemetry.contrib.mongodb`.

Synonyms: *Instrumentation Library*
Synonyms: *Instrumenting Library*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @arminru @Oberon00 you are the masters of these terms :)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄
That's alright this way. Currently, Instrumentation Library is listed as a synonym for Instrumentation Library.

Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tyler! 🙂

Would be great if you could also add this one while you're at it:
#539 (comment)

figured out I could do that myself :)

@bogdandrutu bogdandrutu merged commit 237ab5f into open-telemetry:master May 19, 2020
@MrAlias MrAlias deleted the instrumenting branch May 19, 2020 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants