Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add finishing the currently active span to tracer operations #516

Closed
wants to merge 2 commits into from
+2 −1
Closed

add finishing the currently active span to tracer operations #516

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6eda2a2
add finishing the currently active span to tracer operations
tsloughter Mar 14, 2020
247d453
use End intead of Finish for tracer operation
tsloughter Mar 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion specification/api-tracing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,9 @@ The `Tracer` MUST provide functions to:

The `Tracer` SHOULD provide methods to:

- Finish the currently active `Span`
tsloughter marked this conversation as resolved.
Show resolved Hide resolved
- Get the currently active `Span`
- Make a given `Span` as active
- Make a given `Span` active

The `Tracer` MUST internally leverage the `Context` in order to get and set the
current `Span` state and how `Span`s are passed across process boundaries.
Expand Down