Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,4 @@ For non-trivial changes, follow the [change proposal process](https://github.com
* [ ] [`CHANGELOG.md`](https://github.com/open-telemetry/opentelemetry-specification/blob/main/CHANGELOG.md) file updated for non-trivial changes
* For trivial changes, include `[chore]` in the PR title to skip the changelog check
* [ ] [Spec compliance matrix](https://github.com/open-telemetry/opentelemetry-specification/blob/main/spec-compliance-matrix/template.yaml) updated if necessary
* [ ] [Declarative config data model](https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/configuration/data-model.md#overview) is updated if SDK config surface is changed
2 changes: 2 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,8 @@ release.
- Declarative configuration: add in-development guidance for exposing the
effective `Resource` returned by `Create`.
([#4948](https://github.com/open-telemetry/opentelemetry-specification/issues/4948))
- Require spec changes to consider declarative config schema
([#4916](https://github.com/open-telemetry/opentelemetry-specification/pull/4916))

### Supplementary Guidelines

Expand Down
7 changes: 7 additions & 0 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,13 @@ Smaller changes can follow a shorter process:
support of that SIG's maintainers. For example, this may be an unmerged
PR with an indication of maintainers' intent to merge in the event the
corresponding specification PR is merged.
- If the change adds or modifies the configuration surface area of SDK
components, the PR description must provide links to corresponding proposed
changes to
the [declarative configuration schema](https://github.com/open-telemetry/opentelemetry-configuration).
Approval and merging of such PRs should result in merging the corresponding
Comment thread
dashpole marked this conversation as resolved.
schema PR. This ensures that proposals are evaluated holistically and that the
schema stays in sync with the specification.
Comment thread
jack-berg marked this conversation as resolved.

Trivial changes, such as clarifications, wording changes, spelling/grammar
corrections, etc. can be made directly via pull requests and do not require an associated
Expand Down
Loading