Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zipkin Exporter: Set the ServiceName from the resource attributes #472

Merged
merged 1 commit into from
May 30, 2020
Merged

Zipkin Exporter: Set the ServiceName from the resource attributes #472

merged 1 commit into from
May 30, 2020
+23 −2

Conversation

SergeyKanzhelev
Copy link
Member

Next step for #220

Trying to keep PRs small and uncontroversial

@SergeyKanzhelev SergeyKanzhelev mentioned this pull request Feb 18, 2020
Merged
@arminru arminru changed the title Set the ServiceName from the resource attributes Zipkin Exporter: Set the ServiceName from the resource attributes Feb 19, 2020
jmacd
jmacd approved these changes Mar 18, 2020
View reviewed changes
specification/exporter-zipkin.md Outdated Show resolved Hide resolved
@dyladan dyladan mentioned this pull request Apr 1, 2020
Closed
bogdandrutu
bogdandrutu reviewed Apr 22, 2020
View reviewed changes
specification/exporter-zipkin.md Outdated Show resolved Hide resolved
specification/exporter-zipkin.md Outdated Show resolved Hide resolved
@bogdandrutu bogdandrutu mentioned this pull request Apr 22, 2020
Merged
codefromthecrypt
codefromthecrypt reviewed Apr 22, 2020
View reviewed changes
Copy link

@codefromthecrypt codefromthecrypt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

made some comments as requested. be very careful with this resource thing, as if not consistent in a local root it will cause problems.

specification/exporter-zipkin.md Outdated Show resolved Hide resolved
@bogdandrutu
Copy link
Member

@SergeyKanzhelev please rebase :)

@SergeyKanzhelev SergeyKanzhelev merged commit cbeb0ec into open-telemetry:master May 30, 2020
@SergeyKanzhelev SergeyKanzhelev deleted the sergkanz/zipkinNext branch May 30, 2020 00:16
@dyladan dyladan mentioned this pull request Jun 1, 2020
Closed
@carlosalberto carlosalberto added this to the v0.5 milestone Jun 9, 2020
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
@SergeyKanzhelev
zipkin service name (open-telemetry#472)
808118f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arminru arminru arminru left review comments

@tigrannajaryan tigrannajaryan tigrannajaryan left review comments

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@codefromthecrypt codefromthecrypt codefromthecrypt left review comments

@jmacd jmacd jmacd approved these changes

@c24t c24t Awaiting requested review from c24t

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@iredelmeier iredelmeier Awaiting requested review from iredelmeier

@reyang reyang Awaiting requested review from reyang

@tedsuo tedsuo Awaiting requested review from tedsuo

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.5
Development

Successfully merging this pull request may close these issues.
7 participants
@SergeyKanzhelev @bogdandrutu @codefromthecrypt @jmacd @tigrannajaryan @arminru @carlosalberto