feat(exporters): add user-agent enrichment#4560
Conversation
|
Maybe Collector folks should review this too @mx-psi ? |
|
My understanding is that Collector components are not, as a general rule, bound by the spec. I guess we can add this to our coding guidelines in the Collector as well if it gets approved here to make sure it is followed |
…telemetry-specification into enrich-user-agent-header
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
not stale |
|
@open-telemetry/spec-sponsors sorry for the noise but I do not know exactly who to ping for this review |
reyang
left a comment
reyang
left a comment
There was a problem hiding this comment.
LGTM assuming a changelog entry will be added.
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Link checking is failing in a file unrelated to this PR https://github.com/open-telemetry/opentelemetry-specification/actions/runs/16450064559/job/46492635216?pr=4560 |
Co-authored-by: Trent Mick <trentm@gmail.com>
Co-authored-by: Cijo Thomas <cithomas@microsoft.com>
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
|
I think this is good to merge now. @cijothomas do you have permission to merge this? If so, would you mind doing it? |
I don't. Only spec-maintainers can merge. After getting enough approvals, they typically wait couple days before merging to see any new comments show up. |
|
Let's confirm with @dyladan who provided feedback recently ;) |
|
Ping @dyladan |
JamieDanielson
left a comment
JamieDanielson
left a comment
There was a problem hiding this comment.
This seems reasonable to me
### Entities - Specify entity information via an environment variable. ([#4594](#4594)) ### Common - OTLP Exporters may allow devs to prepend a product identifier in `User-Agent` header. ([#4560](#4560)) -⚠️ **IMPORTANT**: Extending the set of standard attribute value types is no longer a breaking change. ([#4614](#4614)) ### OTEPs - Clarify in Composite Samplers OTEP the unreliable threshold case. ([#4569](#4569)) --------- Co-authored-by: Armin Ruech <7052238+arminru@users.noreply.github.com>
11 participants
Fixes #4479
Changes
Document that exporters may allow a
user-agentoption to append a product identifier to the exporter User Agent header. such option is only available via local var (not environment)For non-trivial changes, follow the change proposal process.
CHANGELOG.mdfile updated for non-trivial changesspec-compliance-matrix.mdupdated if necessary