Skip to content

Stabilize SDK and No-Op Logger.Enabled #4536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlosalberto merged 6 commits into from
Jun 16, 2025
Merged

Stabilize SDK and No-Op Logger.Enabled #4536

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b0fe87c
Stabilize SDK's Logger.Enabled
pellared Jun 3, 2025
89d1079
Stabilize in NOOP
pellared Jun 3, 2025
dbceb1f
Mark some criteria as Development
pellared Jun 3, 2025
8347aa1
Merge branch 'main' into stab-sdk-logger-enabled
trask Jun 12, 2025
8d394b6
Merge branch 'main' into stab-sdk-logger-enabled
pellared Jun 12, 2025
d376fb3
Merge branch 'main' into stab-sdk-logger-enabled
carlosalberto Jun 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ release.

- Stabilize `Event Name` parameter of `Logger.Enabled`.
([#4534](https://github.com/open-telemetry/opentelemetry-specification/pull/4534))
- Stabilize SDK and No-Op `Logger.Enabled`.
([#4536](https://github.com/open-telemetry/opentelemetry-specification/pull/4536))

### Baggage

Expand Down
4 changes: 1 addition & 3 deletions specification/logs/noop.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ linkTitle: No-Op

# Logs API No-Op Implementation

**Status**: [Stable](../document-status.md), except where otherwise specified
**Status**: [Stable](../document-status.md)

<details>
<summary> Table of Contents </summary>
Expand Down Expand Up @@ -59,6 +59,4 @@ for [emitting LogRecords](./api.md#emit-a-logrecord).

### Enabled

**Status**: [Development](../document-status.md)

MUST always return `false`.
8 changes: 4 additions & 4 deletions specification/logs/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,13 +200,13 @@ the implementation SHOULD set it equal to the current time.

### Enabled

**Status**: [Development](../document-status.md)

`Enabled` MUST return `false` when either:

- there are no registered [`LogRecordProcessors`](#logrecordprocessor),
Comment thread
pellared marked this conversation as resolved.
- `Logger` is disabled ([`LoggerConfig.disabled`](#loggerconfig) is `true`),
- all registered `LogRecordProcessors` implement [`Enabled`](#enabled-1),
- **Status**: [Development](../document-status.md) - `Logger` is disabled
([`LoggerConfig.disabled`](#loggerconfig) is `true`),
- **Status**: [Development](../document-status.md) - all registered
`LogRecordProcessors` implement [`Enabled`](#enabled-1),
and a call to `Enabled` on each of them returns `false`.

Otherwise, it SHOULD return `true`.
Expand Down
Loading