-
Notifications
You must be signed in to change notification settings - Fork 893
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Declarative config: clarify null vs empty #4269
Merged
jack-berg
merged 6 commits into
open-telemetry:main
from
jack-berg:declarative-config-null-vs-empty
Oct 28, 2024
Merged
Declarative config: clarify null vs empty #4269
jack-berg
merged 6 commits into
open-telemetry:main
from
jack-berg:declarative-config-null-vs-empty
Oct 28, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related PR to adjust the |
marcalff
approved these changes
Oct 21, 2024
lmolkova
approved these changes
Oct 21, 2024
trask
approved these changes
Oct 21, 2024
pellared
reviewed
Oct 22, 2024
pellared
reviewed
Oct 23, 2024
pellared
approved these changes
Oct 24, 2024
svrnm
reviewed
Oct 24, 2024
svrnm
approved these changes
Oct 24, 2024
trask
reviewed
Oct 24, 2024
trask
approved these changes
Oct 25, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Fixes open-telemetry#4181 cc @open-telemetry/configuration-approvers --------- Co-authored-by: Robert Pająk <[email protected]>
brettmc
added a commit
to brettmc/opentelemetry-php
that referenced
this pull request
Dec 11, 2024
since open-telemetry/opentelemetry-specification#4269 empty keys are allows, and NULL is no longer equivalent to unset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4181
cc @open-telemetry/configuration-approvers