Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove restriction that sampler description is immutable #4137

Merged
merged 5 commits into from
Jul 22, 2024
+6 −1
Merged

Remove restriction that sampler description is immutable #4137

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c755a23
Remove restriction that sampler description is immutable
yurishkuro Jul 10, 2024
d813874
Add to changelog
yurishkuro Jul 10, 2024
e0dfa4e
Merge branch 'main' into fix-2095
yurishkuro Jul 10, 2024
ebacf68
Update CHANGELOG.md
pellared Jul 10, 2024
1e175bf
Merge branch 'main' into fix-2095
yurishkuro Jul 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@ release.

### Traces

- Remove restriction that sampler description is immutable.
reyang marked this conversation as resolved.
Show resolved Hide resolved
([#4137](https://github.com/open-telemetry/opentelemetry-specification/pull/4137))

### Metrics

### Logs
Expand Down
4 changes: 3 additions & 1 deletion specification/trace/sdk.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,9 @@ Returns the sampler name or short description with the configuration. This may
be displayed on debug pages or in the logs. Example:
`"TraceIdRatioBased{0.000100}"`.

Description MUST NOT change over time and caller can cache the returned value.
Description MAY change over time, for example, if the sampler supports dynamic
configuration or otherwise adjusts its parameters.
Callers SHOULD NOT cache the returned value.

### Built-in samplers

Expand Down
Loading