Allow cloning of ReadWriteLogRecord #4090
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MrAlias
reviewed
Jun 28, 2024
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
pellared
changed the title
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
cijothomas
reviewed
Jul 18, 2024
cijothomas
approved these changes
Jul 18, 2024
carlosalberto
approved these changes
Jul 24, 2024
|
So IMHO we should merge this, specially after we got @cijothomas's review. A note on why this is added would help? i.e. regarding helping implementing #4062 if applicable. |
In the PR description or the specification itself? |
|
In the Spec ;) |
|
@carlosalberto PTAL c898c54 |
cijothomas
approved these changes
Jul 25, 2024
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 31, 2024
Follows open-telemetry#4062 ## Why 1. There is a need to make a deep copy of a `ReadWriteRecord` in order to implement an experimental isolating processor outside of the SDK (as it is experimental, we prefer to land it to contrib repository first). 2. Allow fine-grained control for the users to make a deep copy only when necessary. This allows users to have more control on the processing e.g. pass a clone to asynchronous processor to avoid race conditions or make performance improvements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4062
Why
ReadWriteRecordin order to implement an experimental isolating processor outside of the SDK (as it is experimental, we prefer to land it to contrib repository first).Pre-work
slog(standard library in Go) also offers cloning records: https://pkg.go.dev/log/slog#Record.Clone