Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prometheus compatibility: clarify that the service triplet is required to be unique by semantic conventions #3945

Merged
merged 2 commits into from
Mar 20, 2024

Conversation

dashpole
Copy link
Contributor

Fixes #3944

OTLP does not include that requirement.

@dashpole dashpole requested review from a team March 15, 2024 19:01
@dashpole dashpole force-pushed the correct_prom_service branch from 8de79e7 to e6b9499 Compare March 15, 2024 19:02
@dashpole
Copy link
Contributor Author

@tigrannajaryan @jsuereth

@tigrannajaryan tigrannajaryan merged commit 032213c into open-telemetry:main Mar 20, 2024
7 checks passed
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
…d to be unique by semantic conventions (open-telemetry#3945)

Fixes
open-telemetry#3944

OTLP does not include that requirement.

Co-authored-by: jack-berg <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect claim in Prometheus compatibility doc
6 participants